From 407ce43a5e0bb079b3d0db802a2f7367c2f97c99 Mon Sep 17 00:00:00 2001 From: Joao Date: Mon, 4 Sep 2017 11:02:38 +0200 Subject: [PATCH] fixes #33777 --- src/vs/base/browser/ui/list/listWidget.ts | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/src/vs/base/browser/ui/list/listWidget.ts b/src/vs/base/browser/ui/list/listWidget.ts index 4463fe444c0..3a4e10f7b26 100644 --- a/src/vs/base/browser/ui/list/listWidget.ts +++ b/src/vs/base/browser/ui/list/listWidget.ts @@ -84,14 +84,9 @@ class TraitRenderer implements IRenderer } splice(start: number, deleteCount: number): void { - for (let i = 0; i < deleteCount; i++) { - const key = `key_${start + i}`; - const data = this.rendered[key]; - - if (data) { - data.elementDisposable.dispose(); - } - } + this.rendered + .filter(({ index }) => index >= start && index < start + deleteCount) + .forEach(({ templateData }) => templateData.elementDisposable.dispose()); } disposeTemplate(templateData: ITraitTemplateData): void {