Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-24 18:49:00 +01:00
Code Issues Packages Projects Releases Wiki Activity

Only apply TS Dot Accept Suggestion if Previous Character is a valid identifier (#18063)

Browse Source 
* Only apply TS Dot Accept Suggestion if previous character is a valid identifier char

Fixes #17825
Fixes #17770
Fixes #17584

**Bug**
When typing two or more `.` in a row, we end up unexpectedly accepting suggestions in TS files. This is caused by the custom keybinding that ts registers for `.`.

**Fix**
Only accept the suggestion on `.` if the previous character is a valid identifier character.

* Move title to nls
This commit is contained in:
Matt Bierner
2017-01-09 10:43:59 -08:00
committed by GitHub
parent 1fafbd089d
commit 41cb5ee5ae
3 changed files with 19 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
extensions/typescript/package.json
View File

@@ -257,7 +257,7 @@
},
"keybindings": {
"key": ".",
"command": "^acceptSelectedSuggestion",
"command": "typescript.tryAcceptSelectedSuggestionOnDot",
"when": "editorTextFocus && suggestWidgetVisible && editorLangId == 'typescript' && suggestionSupportsAcceptOnKey"
},
"commands": [
@@ -268,6 +268,10 @@
{
"command": "javascript.reloadProjects",
"title": "%javascript.reloadProjects.title%"
},
{
"command": "typescript.tryAcceptSelectedSuggestionOnDot",
"title": "%typescript.tryAcceptSelectedSuggestionOnDot.title%"
}
],
"breakpoints": [