Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-24 18:49:00 +01:00
Code Issues Packages Projects Releases Wiki Activity

Only apply TS Dot Accept Suggestion if Previous Character is a valid identifier (#18063)

Browse Source 
* Only apply TS Dot Accept Suggestion if previous character is a valid identifier char

Fixes #17825
Fixes #17770
Fixes #17584

**Bug**
When typing two or more `.` in a row, we end up unexpectedly accepting suggestions in TS files. This is caused by the custom keybinding that ts registers for `.`.

**Fix**
Only accept the suggestion on `.` if the previous character is a valid identifier character.

* Move title to nls
This commit is contained in:
Matt Bierner
2017-01-09 10:43:59 -08:00
committed by GitHub
parent 1fafbd089d
commit 41cb5ee5ae
3 changed files with 19 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
extensions/typescript/package.nls.json
View File

@@ -12,6 +12,7 @@
"typescript.tsserver.experimentalAutoBuild": "Enables experimental auto build. Requires 1.9 dev or 2.x tsserver version and a restart of VS Code after changing it.",
"typescript.validate.enable": "Enable/disable TypeScript validation.",
"typescript.format.enable": "Enable/disable default TypeScript formatter.",
"typescript.tryAcceptSelectedSuggestionOnDot": "Accept current suggestion when a dot is typed",
"javascript.format.enable": "Enable/disable default JavaScript formatter.",
"format.insertSpaceAfterCommaDelimiter": "Defines space handling after a comma delimiter.",
"format.insertSpaceAfterSemicolonInForStatements": " Defines space handling after a semicolon in a for statement.",