Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-21 00:59:03 +01:00
Code Issues Packages Projects Releases Wiki Activity

Don't upgrade ts unused diagnostics

Browse Source 
These diagnostics should only ever be downgraded from errors to warnings, not ever upgraded from a lower level to warnings
This commit is contained in:
Matt Bierner
2018-04-09 15:07:59 -07:00
parent 7b62b2d8d3
commit 424b95bfcf
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
extensions/typescript-language-features/src/typeScriptServiceClientHost.ts
View File

@@ -255,7 +255,10 @@ export default class TypeScriptServiceClientHost {
}
private getDiagnosticSeverity(diagnostic: Proto.Diagnostic): DiagnosticSeverity {
if (this.reportStyleCheckAsWarnings && this.isStyleCheckDiagnostic(diagnostic.code)) {
if (this.reportStyleCheckAsWarnings
&& this.isStyleCheckDiagnostic(diagnostic.code)
&& diagnostic.category === PConst.DiagnosticCategory.error
) {
return DiagnosticSeverity.Warning;
}