Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-23 18:19:12 +01:00
Code Issues Packages Projects Releases Wiki Activity

Include server id in telemetry and in user issue reports

Browse Source 
From https://github.com/microsoft/TypeScript/issues/39795#issuecomment-668250348
This commit is contained in:
Matt Bierner
2020-08-03 16:03:27 -07:00
parent 358cc674a7
commit 4430401028
2 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
extensions/typescript-language-features/src/tsServer/serverError.ts
View File

@@ -18,7 +18,7 @@ export class TypeScriptServerError extends Error {
}
private constructor(
serverId: string,
public readonly serverId: string,
public readonly version: TypeScriptVersion,
private readonly response: Proto.Response,
public readonly serverMessage: string | undefined,
@@ -38,11 +38,13 @@ export class TypeScriptServerError extends Error {
/* __GDPR__FRAGMENT__
"TypeScriptRequestErrorProperties" : {
"command" : { "classification": "SystemMetaData", "purpose": "FeatureInsight" },
"sanitizedstack" : { "classification": "SystemMetaData", "purpose": "PerformanceAndHealth" }
"serverid" : { "classification": "SystemMetaData", "purpose": "PerformanceAndHealth" },
"sanitizedstack" : { "classification": "SystemMetaData", "purpose": "PerformanceAndHealth" },
}
*/
return {
command: this.serverCommand,
serverid: this.serverId,
sanitizedstack: this.sanitizedStack || '',
} as const;
}

2
extensions/typescript-language-features/src/typescriptServiceClient.ts
View File

@@ -963,6 +963,8 @@ After enabling this setting, future crash reports will include the server log.`)
sections.push(`**TS Server Error Stack**
Server: \`${error.serverId}\`
\`\`\`
${error.serverStack}
\`\`\``);