From 928af2b8f6d3c700f6725ddce391e431b1543026 Mon Sep 17 00:00:00 2001 From: meganrogge Date: Tue, 27 Jun 2023 14:17:20 -0700 Subject: [PATCH 1/3] fix #186408 --- .../workbench/contrib/chat/browser/chatAccessibilityService.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/vs/workbench/contrib/chat/browser/chatAccessibilityService.ts b/src/vs/workbench/contrib/chat/browser/chatAccessibilityService.ts index f3564aff4d9..4f6ad3b128f 100644 --- a/src/vs/workbench/contrib/chat/browser/chatAccessibilityService.ts +++ b/src/vs/workbench/contrib/chat/browser/chatAccessibilityService.ts @@ -25,7 +25,7 @@ export class ChatAccessibilityService extends Disposable implements IChatAccessi if (!this._hasReceivedRequest) { this._responsePendingAudioCue = this._audioCueService.playAudioCueLoop(AudioCue.chatResponsePending, CHAT_RESPONSE_PENDING_AUDIO_CUE_LOOP_MS); } - }, CHAT_RESPONSE_PENDING_AUDIO_CUE_LOOP_MS)); + }, 1000)); } acceptRequest(): void { this._audioCueService.playAudioCue(AudioCue.chatRequestSent, true); From 4c91a016bb932d36588085541cf12a8da2b06ba6 Mon Sep 17 00:00:00 2001 From: meganrogge Date: Tue, 27 Jun 2023 14:19:37 -0700 Subject: [PATCH 2/3] use const --- .../workbench/contrib/chat/browser/chatAccessibilityService.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/vs/workbench/contrib/chat/browser/chatAccessibilityService.ts b/src/vs/workbench/contrib/chat/browser/chatAccessibilityService.ts index 4f6ad3b128f..eeca2c8db36 100644 --- a/src/vs/workbench/contrib/chat/browser/chatAccessibilityService.ts +++ b/src/vs/workbench/contrib/chat/browser/chatAccessibilityService.ts @@ -11,6 +11,7 @@ import { IChatAccessibilityService } from 'vs/workbench/contrib/chat/browser/cha import { IChatResponseViewModel } from 'vs/workbench/contrib/chat/common/chatViewModel'; const CHAT_RESPONSE_PENDING_AUDIO_CUE_LOOP_MS = 5000; +const CHAT_RESPONSE_PENDING_ALLOWANCE_MS = 1000; export class ChatAccessibilityService extends Disposable implements IChatAccessibilityService { declare readonly _serviceBrand: undefined; @@ -25,7 +26,7 @@ export class ChatAccessibilityService extends Disposable implements IChatAccessi if (!this._hasReceivedRequest) { this._responsePendingAudioCue = this._audioCueService.playAudioCueLoop(AudioCue.chatResponsePending, CHAT_RESPONSE_PENDING_AUDIO_CUE_LOOP_MS); } - }, 1000)); + }, CHAT_RESPONSE_PENDING_ALLOWANCE_MS)); } acceptRequest(): void { this._audioCueService.playAudioCue(AudioCue.chatRequestSent, true); From e4602428a00b511f985efde7cead7be3f23b5358 Mon Sep 17 00:00:00 2001 From: meganrogge Date: Tue, 27 Jun 2023 14:42:58 -0700 Subject: [PATCH 3/3] fix doc --- .../contrib/chat/browser/actions/chatAccessibilityHelp.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/vs/workbench/contrib/chat/browser/actions/chatAccessibilityHelp.ts b/src/vs/workbench/contrib/chat/browser/actions/chatAccessibilityHelp.ts index 560fcb883f4..df58db4d97f 100644 --- a/src/vs/workbench/contrib/chat/browser/actions/chatAccessibilityHelp.ts +++ b/src/vs/workbench/contrib/chat/browser/actions/chatAccessibilityHelp.ts @@ -39,7 +39,7 @@ export function getAccessibilityHelpText(accessor: ServicesAccessor, type: 'pane content.push(localize('inlineChat.explain', "When a request is prefixed with /explain, a response will explain the code in the current selection and the chat view will be focused.")); content.push(localize('inlineChat.toolbar', "Use tab to reach conditional parts like commands, status, message responses and more.")); } - content.push(localize('chat.audioCues', "Audio cues can be changed via settings with a prefix of audioCues.chat. By default, if a request takes more than 5 seconds, you will hear an audio cue indicating that progress is still occurring.")); + content.push(localize('chat.audioCues', "Audio cues can be changed via settings with a prefix of audioCues.chat. By default, if a request takes more than a second, you will hear an audio cue indicating that progress is still occurring.")); return content.join('\n'); }