Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-29 21:11:38 +01:00
Code Issues Packages Projects Releases Wiki Activity

more linting in workbench

Browse Source
This commit is contained in:
Benjamin Pasero
2015-12-21 17:35:25 +01:00
parent 54782e5a5f
commit 465fc4f58b
40 changed files with 70 additions and 126 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
src/vs/workbench/node/pluginHostMain.ts
View File

@@ -15,10 +15,8 @@ import pfs = require('vs/base/node/pfs');
import URI from 'vs/base/common/uri';
import {TPromise} from 'vs/base/common/winjs.base';
import json = require('vs/base/common/json');
import strings = require('vs/base/common/strings');
import paths = require('vs/base/common/paths');
import {IPluginService, IPluginDescription, IMessage} from 'vs/platform/plugins/common/plugins';
import {IPluginService, IPluginDescription} from 'vs/platform/plugins/common/plugins';
import {PluginsRegistry, PluginsMessageCollector, IPluginsMessageCollector} from 'vs/platform/plugins/common/pluginsRegistry';
import {ExtHostAPIImplementation} from 'vs/workbench/api/browser/extHost.api.impl';
import { create as createIPC, IPluginsIPC } from 'vs/platform/plugins/common/ipcRemoteCom';
@@ -32,11 +30,7 @@ import {ExtHostTelemetryService} from 'vs/workbench/api/common/extHostTelemetry'
import {BaseRequestService} from 'vs/platform/request/common/baseRequestService';
import {BaseWorkspaceContextService} from 'vs/platform/workspace/common/baseWorkspaceContextService';
import {ModeServiceImpl} from 'vs/editor/common/services/modeServiceImpl';
import {IThemeExtensionPoint} from 'vs/platform/theme/common/themeExtensionPoint';
import {ILanguageExtensionPoint} from 'vs/editor/common/modes/languageExtensionPoint';
import {ITMSyntaxExtensionPoint} from 'vs/editor/node/textMate/TMSyntax';
import {PluginScanner} from 'vs/workbench/node/extensionPoints';
import Severity from 'vs/base/common/severity';
import { IWorkspaceContextService } from 'vs/platform/workspace/common/workspace';
import { Client } from 'vs/base/node/service.net';
import { IExtensionsService } from 'vs/workbench/parts/extensions/common/extensions';
@@ -99,7 +93,7 @@ export function createServices(remoteCom: IPluginsIPC, initData: IInitData, shar
}
interface ITestRunner {
run(testsRoot:string, clb: (error:Error, failures?: number) => void): void;
run(testsRoot: string, clb: (error: Error, failures?: number) => void): void;
}
export class PluginHostMain {
@@ -133,13 +127,13 @@ export class PluginHostMain {
activatedExtensions.forEach((extensionId) => {
this.pluginService.deactivate(extensionId);
});
} catch(err) {
} catch (err) {
// TODO: write to log once we have one
}
// Give extensions 1 second to wrap up any async dispose, then exit
setTimeout(() => {
exit()
exit();
}, 1000);
}
@@ -252,8 +246,8 @@ export class PluginHostMain {
}
// Require the test runner via node require from the provided path
let testRunner:ITestRunner;
let requireError:Error;
let testRunner: ITestRunner;
let requireError: Error;
try {
testRunner = <any>require.__$__nodeRequire(env.pluginTestsPath);
} catch (error) {

4
src/vs/workbench/node/pluginHostProcess.ts
View File

@@ -18,7 +18,7 @@ interface IRendererConnection {
// This calls exit directly in case the initialization is not finished and we need to exit
// Otherwise, if initialization completed we go to pluginHostMain.terminate()
var onTerminate = function() {
let onTerminate = function() {
exit();
};
@@ -70,7 +70,7 @@ function connectToRenderer(): TPromise<IRendererConnection> {
setInterval(function() {
if (stats.length >= 250) {
let total = stats.reduce((prev, current) => prev + current, 0);
console.warn(`MANY messages are being SEND FROM the extension host!`)
console.warn(`MANY messages are being SEND FROM the extension host!`);
console.warn(`SEND during 1sec: message_count=${stats.length}, total_len=${total}`);
}
stats.length = 0;

2
src/vs/workbench/node/userSettings.ts
View File

@@ -18,7 +18,7 @@ import {IWorkspaceContextService} from 'vs/workbench/services/workspace/common/c
export interface ISettings {
settings: any;
settingsParseErrors?: string[];
keybindings: any
keybindings: any;
}
export class UserSettings {