Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2025-12-23 19:59:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix bug for completing function name parameters if function name contained special snippet syntax

Browse Source
This commit is contained in:
Matt Bierner
2018-12-20 13:04:01 -08:00
parent 75071898dc
commit 494e5e8509
2 changed files with 12 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
extensions/typescript-language-features/src/test/functionCallSnippet.test.ts
View File

@@ -107,4 +107,14 @@ suite('typescript function call snippets', () => {
).snippet.value,
'methoda(${1:x})$0');
});
test('Should escape snippet syntax in method name', async () => {
assert.strictEqual(
snippetForFunctionCall(
{ label: '$abc', },
[]
).snippet.value,
'\\$abc()$0');
});
});

3
extensions/typescript-language-features/src/utils/snippetForFunctionCall.ts
View File

@@ -16,7 +16,8 @@ export function snippetForFunctionCall(
}
const parameterListParts = getParameterListParts(displayParts);
const snippet = new vscode.SnippetString(`${item.insertText || item.label}(`);
const snippet = new vscode.SnippetString();
snippet.appendText(`${item.insertText || item.label}(`);
appendJoinedPlaceholders(snippet, parameterListParts.parts, ', ');
if (parameterListParts.hasOptionalParameters) {
snippet.appendTabstop();