diff --git a/src/vs/platform/theme/test/common/testThemeService.ts b/src/vs/platform/theme/test/common/testThemeService.ts
index 6655be6e360..a7911a49048 100644
--- a/src/vs/platform/theme/test/common/testThemeService.ts
+++ b/src/vs/platform/theme/test/common/testThemeService.ts
@@ -14,7 +14,7 @@ export class TestColorTheme implements IColorTheme {
 	public readonly label = 'test';
 
 	constructor(
-		private colors: { [id: string]: string } = {},
+		private colors: { [id: string]: string | undefined } = {},
 		public type = ColorScheme.DARK,
 		public readonly semanticHighlighting = false
 	) { }
diff --git a/src/vs/workbench/contrib/terminal/test/browser/xterm/xtermTerminal.test.ts b/src/vs/workbench/contrib/terminal/test/browser/xterm/xtermTerminal.test.ts
index c9bbe8dedaf..eaec5127e56 100644
--- a/src/vs/workbench/contrib/terminal/test/browser/xterm/xtermTerminal.test.ts
+++ b/src/vs/workbench/contrib/terminal/test/browser/xterm/xtermTerminal.test.ts
@@ -16,7 +16,7 @@ import { IThemeService } from 'vs/platform/theme/common/themeService';
 import { IViewDescriptor, IViewDescriptorService, ViewContainerLocation } from 'vs/workbench/common/views';
 import { IEditorOptions } from 'vs/editor/common/config/editorOptions';
 import { Emitter } from 'vs/base/common/event';
-import { TERMINAL_BACKGROUND_COLOR, TERMINAL_FOREGROUND_COLOR, TERMINAL_CURSOR_FOREGROUND_COLOR, TERMINAL_CURSOR_BACKGROUND_COLOR, TERMINAL_SELECTION_BACKGROUND_COLOR } from 'vs/workbench/contrib/terminal/common/terminalColorRegistry';
+import { TERMINAL_BACKGROUND_COLOR, TERMINAL_FOREGROUND_COLOR, TERMINAL_CURSOR_FOREGROUND_COLOR, TERMINAL_CURSOR_BACKGROUND_COLOR, TERMINAL_SELECTION_BACKGROUND_COLOR, TERMINAL_SELECTION_FOREGROUND_COLOR } from 'vs/workbench/contrib/terminal/common/terminalColorRegistry';
 import { PANEL_BACKGROUND, SIDE_BAR_BACKGROUND } from 'vs/workbench/common/theme';
 import { WebglAddon } from 'xterm-addon-webgl';
 import { ILogService, NullLogService } from 'vs/platform/log/common/log';
@@ -146,6 +146,7 @@ suite('XtermTerminal', () => {
 				[TERMINAL_CURSOR_FOREGROUND_COLOR]: '#000300',
 				[TERMINAL_CURSOR_BACKGROUND_COLOR]: '#000400',
 				[TERMINAL_SELECTION_BACKGROUND_COLOR]: '#000500',
+				[TERMINAL_SELECTION_FOREGROUND_COLOR]: undefined,
 				'terminal.ansiBlack': '#010000',
 				'terminal.ansiRed': '#020000',
 				'terminal.ansiGreen': '#030000',
@@ -170,6 +171,7 @@ suite('XtermTerminal', () => {
 				cursor: '#000300',
 				cursorAccent: '#000400',
 				selection: '#000500',
+				selectionForeground: undefined,
 				black: '#010000',
 				green: '#030000',
 				red: '#020000',
@@ -193,6 +195,7 @@ suite('XtermTerminal', () => {
 				[TERMINAL_CURSOR_FOREGROUND_COLOR]: '#00030f',
 				[TERMINAL_CURSOR_BACKGROUND_COLOR]: '#00040f',
 				[TERMINAL_SELECTION_BACKGROUND_COLOR]: '#00050f',
+				[TERMINAL_SELECTION_FOREGROUND_COLOR]: '#00060f',
 				'terminal.ansiBlack': '#01000f',
 				'terminal.ansiRed': '#02000f',
 				'terminal.ansiGreen': '#03000f',
@@ -216,6 +219,7 @@ suite('XtermTerminal', () => {
 				cursor: '#00030f',
 				cursorAccent: '#00040f',
 				selection: '#00050f',
+				selectionForeground: '#00060f',
 				black: '#01000f',
 				green: '#03000f',
 				red: '#02000f',