Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-21 17:19:01 +01:00
Code Issues Packages Projects Releases Wiki Activity

add additional logging around github auth

Browse Source
This commit is contained in:
Tyler Leonhardt
2021-06-28 16:27:52 -07:00
parent c4cde2147a
commit 4a011b5297
4 changed files with 14 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
extensions/github-authentication/src/common/keychain.ts
View File

@@ -46,7 +46,11 @@ export class Keychain {
async getToken(): Promise<string | null | undefined> {
try {
return await this.context.secrets.get(this.serviceId);
const secret = await this.context.secrets.get(this.serviceId);
if (secret && secret !== '[]') {
Logger.trace('Token acquired from secret storage.');
}
return secret;
} catch (e) {
// Ignore
Logger.error(`Getting token failed: ${e}`);
@@ -73,6 +77,7 @@ export class Keychain {
const oldValue = await keytar.getPassword(`${vscode.env.uriScheme}-github.login`, 'account');
if (oldValue) {
Logger.trace('Attempting to migrate from keytar to secret store...');
await this.setToken(oldValue);
await keytar.deletePassword(`${vscode.env.uriScheme}-github.login`, 'account');
}