registerNotebookCellStatusBarItemProvider should use viewType instead of NotebookSelector

Fix #122347
This commit is contained in:
Rob Lourens
2021-05-07 15:23:19 -07:00
parent 450e5d164e
commit 4a76f0b19a
9 changed files with 40 additions and 59 deletions

View File

@@ -228,13 +228,13 @@ export class ExtHostNotebookController implements ExtHostNotebookShape {
};
}
registerNotebookCellStatusBarItemProvider(extension: IExtensionDescription, selector: vscode.NotebookSelector, provider: vscode.NotebookCellStatusBarItemProvider) {
registerNotebookCellStatusBarItemProvider(extension: IExtensionDescription, notebookType: string, provider: vscode.NotebookCellStatusBarItemProvider) {
const handle = ExtHostNotebookController._notebookStatusBarItemProviderHandlePool++;
const eventHandle = typeof provider.onDidChangeCellStatusBarItems === 'function' ? ExtHostNotebookController._notebookStatusBarItemProviderHandlePool++ : undefined;
this._notebookStatusBarItemProviders.set(handle, provider);
this._notebookProxy.$registerNotebookCellStatusBarItemProvider(handle, eventHandle, selector);
this._notebookProxy.$registerNotebookCellStatusBarItemProvider(handle, eventHandle, notebookType);
let subscription: vscode.Disposable | undefined;
if (eventHandle !== undefined) {