Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-23 18:19:12 +01:00
Code Issues Packages Projects Releases Wiki Activity

Batch diagnostic updates

Browse Source 
Fixes #48925
This commit is contained in:
Matt Bierner
2018-05-23 14:06:01 -07:00
parent 5d8467dffe
commit 4b6922f100
1 changed files with 22 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
extensions/typescript-language-features/src/features/diagnostics.ts
View File

@@ -40,9 +40,12 @@ export class DiagnosticsManager {
private readonly _diagnostics = new Map<DiagnosticKind, DiagnosticSet>();
private readonly _currentDiagnostics: vscode.DiagnosticCollection;
private readonly _pendingUpdates: { [key: string]: any } = Object.create(null);
private _validate: boolean = true;
private _enableSuggestions: boolean = true;
private readonly updateDelay = 50;
constructor(
owner: string
) {
@@ -55,6 +58,11 @@ export class DiagnosticsManager {
public dispose() {
this._currentDiagnostics.dispose();
for (const key in Object.keys(this._pendingUpdates)) {
clearTimeout(this._pendingUpdates[key]);
delete this._pendingUpdates[key];
}
}
public reInitialize(): void {
@@ -93,9 +101,15 @@ export class DiagnosticsManager {
diagnostics: vscode.Diagnostic[]
): void {
const collection = this._diagnostics.get(kind);
if (collection) {
collection.set(file, diagnostics);
this.updateCurrentDiagnostics(file);
if (!collection) {
return;
}
collection.set(file, diagnostics);
const key = file.fsPath;
if (!this._pendingUpdates[key]) {
this._pendingUpdates[key] = setTimeout(() => this.updateCurrentDiagnostics(file), this.updateDelay);
}
}
@@ -108,6 +122,11 @@ export class DiagnosticsManager {
}
private updateCurrentDiagnostics(file: vscode.Uri) {
if (this._pendingUpdates[file.fsPath]) {
clearTimeout(this._pendingUpdates[file.fsPath]);
delete this._pendingUpdates[file.fsPath];
}
if (!this._validate) {
return;
}