From ada5b97fb9007c90bc4ce6581f1e61ade66a249b Mon Sep 17 00:00:00 2001
From: Jacob Jaeggli <13710580+jjaeggli@users.noreply.github.com>
Date: Fri, 28 Jul 2023 09:47:03 -0700
Subject: [PATCH 1/2] Notify with aria.status when "loading" or "No
 suggestions" is displayed.

---
 src/vs/editor/contrib/suggest/browser/suggestWidget.ts | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/src/vs/editor/contrib/suggest/browser/suggestWidget.ts b/src/vs/editor/contrib/suggest/browser/suggestWidget.ts
index 8cbfc6ef9cb..470fc312676 100644
--- a/src/vs/editor/contrib/suggest/browser/suggestWidget.ts
+++ b/src/vs/editor/contrib/suggest/browser/suggestWidget.ts
@@ -34,6 +34,7 @@ import { CompletionItem, Context as SuggestContext, suggestWidgetStatusbarMenu }
 import { canExpandCompletionItem, SuggestDetailsOverlay, SuggestDetailsWidget } from './suggestWidgetDetails';
 import { getAriaId, ItemRenderer } from './suggestWidgetRenderer';
 import { getListStyles } from 'vs/platform/theme/browser/defaultStyles';
+import { status } from 'vs/base/browser/ui/aria/aria';
 
 /**
  * Suggest widget colors
@@ -206,6 +207,9 @@ export class SuggestWidget implements IDisposable {
 		}));
 
 		this._messageElement = dom.append(this.element.domNode, dom.$('.message'));
+		// this._messageElement.setAttribute('aria-live', 'polite');
+		// this._messageElement.setAttribute('aria-atomic', 'true');
+		// this._messageElement.setAttribute('role', 'alert');
 		this._listElement = dom.append(this.element.domNode, dom.$('.tree'));
 
 		const details = instantiationService.createInstance(SuggestDetailsWidget, this.editor);
@@ -463,6 +467,7 @@ export class SuggestWidget implements IDisposable {
 				this._details.hide();
 				this._show();
 				this._focusedItem = undefined;
+				status(SuggestWidget.LOADING_MESSAGE);
 				break;
 			case State.Empty:
 				this.element.domNode.classList.add('message');
@@ -472,6 +477,7 @@ export class SuggestWidget implements IDisposable {
 				this._details.hide();
 				this._show();
 				this._focusedItem = undefined;
+				status(SuggestWidget.NO_SUGGESTIONS_MESSAGE);
 				break;
 			case State.Open:
 				dom.hide(this._messageElement);

From fb8b07d3c13979b92c0f89407aa78473c65af822 Mon Sep 17 00:00:00 2001
From: Jacob Jaeggli <13710580+jjaeggli@users.noreply.github.com>
Date: Fri, 28 Jul 2023 09:57:23 -0700
Subject: [PATCH 2/2] Remove comments.

---
 src/vs/editor/contrib/suggest/browser/suggestWidget.ts | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/src/vs/editor/contrib/suggest/browser/suggestWidget.ts b/src/vs/editor/contrib/suggest/browser/suggestWidget.ts
index 470fc312676..09ebd2bdda0 100644
--- a/src/vs/editor/contrib/suggest/browser/suggestWidget.ts
+++ b/src/vs/editor/contrib/suggest/browser/suggestWidget.ts
@@ -207,9 +207,6 @@ export class SuggestWidget implements IDisposable {
 		}));
 
 		this._messageElement = dom.append(this.element.domNode, dom.$('.message'));
-		// this._messageElement.setAttribute('aria-live', 'polite');
-		// this._messageElement.setAttribute('aria-atomic', 'true');
-		// this._messageElement.setAttribute('role', 'alert');
 		this._listElement = dom.append(this.element.domNode, dom.$('.tree'));
 
 		const details = instantiationService.createInstance(SuggestDetailsWidget, this.editor);