Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-23 01:58:53 +01:00
Code Issues Packages Projects Releases Wiki Activity

Validating device ID slows down window opening (fix #234064) (#234065)

Browse Source
This commit is contained in:
Benjamin Pasero
2024-11-18 09:17:14 +01:00
committed by GitHub
parent 0c9dd26823
commit 4bfa2f866d
1 changed files with 15 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
src/vs/code/electron-main/app.ts
View File

@@ -622,7 +622,14 @@ export class CodeApplication extends Disposable {
// Set lifecycle phase to `Eventually` after a short delay and when idle (min 2.5sec, max 5sec)
const eventuallyPhaseScheduler = this._register(new RunOnceScheduler(() => {
this._register(runWhenGlobalIdle(() => this.lifecycleMainService.phase = LifecycleMainPhase.Eventually, 2500));
this._register(runWhenGlobalIdle(() => {
// Signal phase: eventually
this.lifecycleMainService.phase = LifecycleMainPhase.Eventually;
// Eventually Post Open Window Tasks
this.eventuallyAfterWindowOpen();
}, 2500));
}, 2500));
eventuallyPhaseScheduler.schedule();
}
@@ -1373,9 +1380,6 @@ export class CodeApplication extends Disposable {
if (isMacintosh && app.runningUnderARM64Translation) {
this.windowsMainService?.sendToFocused('vscode:showTranslatedBuildWarning');
}
// Validate Device ID is up to date
validatedevDeviceId(this.stateService, this.logService);
}
private async installMutex(): Promise<void> {
@@ -1451,4 +1455,11 @@ export class CodeApplication extends Disposable {
this.windowsMainService?.sendToFocused('vscode:showArgvParseWarning');
}
}
private eventuallyAfterWindowOpen(): void {
// Validate Device ID is up to date (delay this as it has shown significant perf impact)
// Refs: https://github.com/microsoft/vscode/issues/234064
validatedevDeviceId(this.stateService, this.logService);
}
}