diff --git a/src/vs/vscode.proposed.d.ts b/src/vs/vscode.proposed.d.ts index 848e9f8c717..b1166a8a38e 100644 --- a/src/vs/vscode.proposed.d.ts +++ b/src/vs/vscode.proposed.d.ts @@ -1075,14 +1075,16 @@ declare module 'vscode' { } export interface TerminalLinkProvider { + /** + * Provide terminal links for the given context. + * @param context Information about what links are being provided for. + */ provideTerminalLinks(context: TerminalLinkContext): ProviderResult /** * Handle an activated terminal link. - * - * @returns Whether the link was handled, if not VS Code will attempt to open it. */ - handleTerminalLink(link: T): ProviderResult; + handleTerminalLink(link: T): void; } export interface TerminalLink { @@ -1096,12 +1098,6 @@ declare module 'vscode' { */ length: number; - /** - * The uri this link points to. If set, and {@link TerminalLinkProvider.handlerTerminalLink} - * is not implemented or returns false, then VS Code will try to open the Uri. - */ - target?: Uri; - /** * The tooltip text when you hover over this link. * diff --git a/src/vs/workbench/api/common/extHostTerminalService.ts b/src/vs/workbench/api/common/extHostTerminalService.ts index dc47c5d8b79..4f73333c27a 100644 --- a/src/vs/workbench/api/common/extHostTerminalService.ts +++ b/src/vs/workbench/api/common/extHostTerminalService.ts @@ -651,9 +651,6 @@ export abstract class BaseExtHostTerminalService implements IExtHostTerminalServ return; } cachedLink.provider.handleTerminalLink(cachedLink.link); - // TODO: Handle when result is false? Should this be return void instead and remove - // TerminalLink.target? It's a simple call to window.openUri for the extension otherwise - // and would simplify the API. } private _onProcessExit(id: number, exitCode: number | undefined): void {