Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-05-08 09:08:48 +01:00
Code Issues Packages Projects Releases Wiki Activity

Don't allow one click reporting of TS Server crashes against VS Code repo when TS server plugins are enabled (#175186)

Browse Source 
Don't allow one click reporting of TS Server crashes when TS server plugins are enabled

Fixes #175184
This commit is contained in:
Matt Bierner
2023-02-22 17:26:18 -06:00
committed by GitHub
parent f105526bbe
commit 4d247bae44
1 changed files with 25 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files
extensions/typescript-language-features/src/typescriptServiceClient.ts
+25 -16
View File
@@ -605,11 +605,14 @@ export default class TypeScriptServiceClient extends Disposable implements IType
this.lastStart = Date.now(); this.lastStart = Date.now();
startService = false; startService = false;
this.hasServerFatallyCrashedTooManyTimes = true; this.hasServerFatallyCrashedTooManyTimes = true;
prompt = vscode.window.showErrorMessage( if (this.pluginManager.plugins.length) {
this.pluginManager.plugins.length prompt = vscode.window.showErrorMessage<vscode.MessageItem>(
? vscode.l10n.t("The JS/TS language service immediately crashed 5 times. The service will not be restarted.\nThis may be caused by a plugin contributed by one of these extensions: {0}", pluginExtensionList) vscode.l10n.t("The JS/TS language service immediately crashed 5 times. The service will not be restarted.\nThis may be caused by a plugin contributed by one of these extensions: {0}.\nPlease try disabling these extensions before filing an issue against VS Code.", pluginExtensionList));
: vscode.l10n.t("The JS/TS language service immediately crashed 5 times. The service will not be restarted."), } else {
reportIssueItem); prompt = vscode.window.showErrorMessage(
vscode.l10n.t("The JS/TS language service immediately crashed 5 times. The service will not be restarted."),
reportIssueItem);
}
/* __GDPR__ /* __GDPR__
"serviceExited" : { "serviceExited" : {
@@ -623,22 +626,28 @@ export default class TypeScriptServiceClient extends Disposable implements IType
} else if (diff < 60 * 1000 * 5 /* 5 Minutes */) { } else if (diff < 60 * 1000 * 5 /* 5 Minutes */) {
this.lastStart = Date.now(); this.lastStart = Date.now();
if (!this._isPromptingAfterCrash) { if (!this._isPromptingAfterCrash) {
prompt = vscode.window.showWarningMessage( if (this.pluginManager.plugins.length) {
this.pluginManager.plugins.length prompt = vscode.window.showWarningMessage<vscode.MessageItem>(
? vscode.l10n.t("The JS/TS language service crashed 5 times in the last 5 Minutes.\nThis may be caused by a plugin contributed by one of these extensions: {0}", pluginExtensionList) vscode.l10n.t("The JS/TS language service crashed 5 times in the last 5 Minutes.\nThis may be caused by a plugin contributed by one of these extensions: {0}\nPlease try disabling these extensions before filing an issue against VS Code.", pluginExtensionList));
: vscode.l10n.t("The JS/TS language service crashed 5 times in the last 5 Minutes."), } else {
reportIssueItem); prompt = vscode.window.showWarningMessage(
vscode.l10n.t("The JS/TS language service crashed 5 times in the last 5 Minutes."),
reportIssueItem);
}
} }
} }
} else if (['vscode-insiders', 'code-oss'].includes(vscode.env.uriScheme)) { } else if (['vscode-insiders', 'code-oss'].includes(vscode.env.uriScheme)) {
// Prompt after a single restart // Prompt after a single restart
this.numberRestarts = 0; this.numberRestarts = 0;
if (!this._isPromptingAfterCrash) { if (!this._isPromptingAfterCrash) {
prompt = vscode.window.showWarningMessage( if (this.pluginManager.plugins.length) {
this.pluginManager.plugins.length prompt = vscode.window.showWarningMessage<vscode.MessageItem>(
? vscode.l10n.t("The JS/TS language service crashed.\nThis may be caused by a plugin contributed by one of these extensions: {0}", pluginExtensionList) vscode.l10n.t("The JS/TS language service crashed.\nThis may be caused by a plugin contributed by one of these extensions: {0}.\nPlease try disabling these extensions before filing an issue against VS Code.", pluginExtensionList));
: vscode.l10n.t("The JS/TS language service crashed."), } else {
reportIssueItem); prompt = vscode.window.showWarningMessage(
vscode.l10n.t("The JS/TS language service crashed."),
reportIssueItem);
}
} }
} }
@@ -1047,7 +1056,7 @@ function getReportIssueArgsForError(
[ [
`**Global TypeScript Server Plugins**`, `**Global TypeScript Server Plugins**`,
`❗️ Please test with extensions disabled. Extensions are the root cause of most TypeScript server crashes`, `❗️ Please test with extensions disabled. Extensions are the root cause of most TypeScript server crashes`,
globalPlugins.map(plugin => `- \`${plugin.name}\``).join('\n') globalPlugins.map(plugin => `- \`${plugin.name}\` contributed by the \`${plugin.extension.id}\` extension`).join('\n')
].join('\n\n') ].join('\n\n')
); );
} }