Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-27 12:04:04 +01:00
Code Issues Packages Projects Releases Wiki Activity

add a way to read marks with source, adopt in perf view editor

Browse Source
This commit is contained in:
Johannes Rieken
2020-12-14 11:54:27 +01:00
parent c666c1d72f
commit 4df387f5ad
3 changed files with 32 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
src/vs/workbench/services/timer/browser/timerService.ts
View File

@@ -333,7 +333,9 @@ export interface ITimerService {
readonly _serviceBrand: undefined;
readonly startupMetrics: Promise<IStartupMetrics>;
submitPerformanceMarks(source: string, marks: perf.PerformanceMark[]): void;
setPerformanceMarks(source: string, marks: perf.PerformanceMark[]): void;
getPerformanceMarks(): [source: string, marks: readonly perf.PerformanceMark[]][];
}
export const ITimerService = createDecorator<ITimerService>('timerService');
@@ -343,7 +345,7 @@ class PerfMarks {
private readonly _entries = new Map<string, perf.PerformanceMark[]>();
submitMarks(source: string, entries: perf.PerformanceMark[]): void {
setMarks(source: string, entries: perf.PerformanceMark[]): void {
if (this._entries.has(source)) {
throw new Error(`${source} EXISTS already`);
}
@@ -359,10 +361,9 @@ class PerfMarks {
if (!toEntry) {
return 0;
}
return Math.round(toEntry.startTime - fromEntry.startTime);
return toEntry.startTime - fromEntry.startTime;
}
private _findEntry(name: string): perf.PerformanceMark | void {
for (let entries of this._entries.values()) {
for (let i = entries.length - 1; i >= 0; i--) {
@@ -372,8 +373,11 @@ class PerfMarks {
}
}
}
}
getEntries() {
return Array.from(this._entries);
}
}
export type Writeable<T> = { -readonly [P in keyof T]: Writeable<T[P]> };
@@ -425,14 +429,18 @@ export abstract class AbstractTimerService implements ITimerService {
const marks: perf.PerformanceMark[] = performance.getEntriesByType('mark').map(entry => {
return {
name: entry.name,
startTime: timeOrigin + entry.startTime
startTime: Math.round(timeOrigin + entry.startTime)
};
});
this.submitPerformanceMarks('renderer', marks);
this.setPerformanceMarks('renderer', marks);
}
submitPerformanceMarks(source: string, marks: perf.PerformanceMark[]): void {
this._marks.submitMarks(source, marks);
setPerformanceMarks(source: string, marks: perf.PerformanceMark[]): void {
this._marks.setMarks(source, marks);
}
getPerformanceMarks(): [source: string, marks: readonly perf.PerformanceMark[]][] {
return this._marks.getEntries();
}
get startupMetrics(): Promise<IStartupMetrics> {

2
src/vs/workbench/services/timer/electron-sandbox/timerService.ts
View File

@@ -33,7 +33,7 @@ export class TimerService extends AbstractTimerService {
@ITelemetryService telemetryService: ITelemetryService,
) {
super(lifecycleService, contextService, extensionService, updateService, viewletService, panelService, editorService, accessibilityService, telemetryService);
this.submitPerformanceMarks('main', _environmentService.configuration.perfMarks);
this.setPerformanceMarks('main', _environmentService.configuration.perfMarks);
}
protected _isInitialStartup(): boolean {