From 4e4cc4c257ff20ec09fdffdb65470c9f5788b60b Mon Sep 17 00:00:00 2001
From: meganrogge <megan.rogge@microsoft.com>
Date: Mon, 12 Feb 2024 12:12:37 -0600
Subject: [PATCH] fix other issue

---
 .../contrib/accessibilitySignals/browser/commands.ts        | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/src/vs/workbench/contrib/accessibilitySignals/browser/commands.ts b/src/vs/workbench/contrib/accessibilitySignals/browser/commands.ts
index 5a7bacde1c5..50db5214d76 100644
--- a/src/vs/workbench/contrib/accessibilitySignals/browser/commands.ts
+++ b/src/vs/workbench/contrib/accessibilitySignals/browser/commands.ts
@@ -109,14 +109,12 @@ export class ShowAccessibilityAnnouncementHelp extends Action2 {
 			for (const signal of enabledAnnouncements) {
 				let { sound, announcement } = configurationService.getValue<{ sound: string; announcement?: string }>(signal.settingsKey);
 				announcement = userGestureSignals.includes(signal) ? 'userGesture' : signal.announcementMessage && accessibilityService.isScreenReaderOptimized() ? 'auto' : undefined;
-				if (announcement) {
-					configurationService.updateValue(signal.settingsKey, { sound, announcement });
-				}
+				configurationService.updateValue(signal.settingsKey, { sound, announcement });
 			}
 			for (const signal of disabledAnnouncements) {
 				const announcement = userGestureSignals.includes(signal) ? 'never' : 'off';
 				const sound = configurationService.getValue(signal.settingsKey + '.sound');
-				configurationService.updateValue(signal.settingsKey, { sound, announcement });
+				configurationService.updateValue(signal.settingsKey, announcement ? { sound, announcement } : { sound });
 			}
 			qp.hide();
 		});