From 4ea9547a11126e8022ae7147b2a046ed6dfdf52c Mon Sep 17 00:00:00 2001 From: Megan Rogge Date: Fri, 7 Nov 2025 11:22:01 -0500 Subject: [PATCH] rm unneeded event (#276108) --- .../terminalContrib/suggest/browser/terminalSuggestAddon.ts | 6 ------ .../services/extensions/common/extensionsRegistry.ts | 5 ----- 2 files changed, 11 deletions(-) diff --git a/src/vs/workbench/contrib/terminalContrib/suggest/browser/terminalSuggestAddon.ts b/src/vs/workbench/contrib/terminalContrib/suggest/browser/terminalSuggestAddon.ts index b45bc015a53..2213c0a1096 100644 --- a/src/vs/workbench/contrib/terminalContrib/suggest/browser/terminalSuggestAddon.ts +++ b/src/vs/workbench/contrib/terminalContrib/suggest/browser/terminalSuggestAddon.ts @@ -24,7 +24,6 @@ import { ITerminalCompletionService } from './terminalCompletionService.js'; import { TerminalSettingId, TerminalShellType, PosixShellType, WindowsShellType, GeneralShellType, ITerminalLogService } from '../../../../../platform/terminal/common/terminal.js'; import { CancellationToken, CancellationTokenSource } from '../../../../../base/common/cancellation.js'; import { createCancelablePromise, CancelablePromise, IntervalTimer, TimeoutTimer } from '../../../../../base/common/async.js'; -import { IExtensionService } from '../../../../services/extensions/common/extensions.js'; import { ThemeIcon } from '../../../../../base/common/themables.js'; import { MenuId } from '../../../../../platform/actions/common/actions.js'; import { ISimpleSuggestWidgetFontInfo } from '../../../../services/suggest/browser/simpleSuggestWidgetRenderer.js'; @@ -179,7 +178,6 @@ export class SuggestAddon extends Disposable implements ITerminalAddon, ISuggest @ITerminalCompletionService private readonly _terminalCompletionService: ITerminalCompletionService, @IConfigurationService private readonly _configurationService: IConfigurationService, @IInstantiationService private readonly _instantiationService: IInstantiationService, - @IExtensionService private readonly _extensionService: IExtensionService, @ITerminalConfigurationService private readonly _terminalConfigurationService: ITerminalConfigurationService, @ITerminalLogService private readonly _logService: ITerminalLogService, ) { @@ -285,10 +283,6 @@ export class SuggestAddon extends Disposable implements ITerminalAddon, ISuggest doNotRequestExtensionCompletions = true; } - if (!doNotRequestExtensionCompletions) { - this._logService.trace('SuggestAddon#_handleCompletionProviders onTerminalCompletionsRequested'); - await this._extensionService.activateByEvent('onTerminalCompletionsRequested'); - } this._currentPromptInputState = { value: this._promptInputModel.value, prefix: this._promptInputModel.prefix, diff --git a/src/vs/workbench/services/extensions/common/extensionsRegistry.ts b/src/vs/workbench/services/extensions/common/extensionsRegistry.ts index c1fc3e31561..f6c18c64321 100644 --- a/src/vs/workbench/services/extensions/common/extensionsRegistry.ts +++ b/src/vs/workbench/services/extensions/common/extensionsRegistry.ts @@ -409,11 +409,6 @@ export const schema: IJSONSchema = { body: 'onTerminal:{1:shellType}', description: nls.localize('vscode.extension.activationEvents.onTerminal', 'An activation event emitted when a terminal of the given shell type is opened.'), }, - { - label: 'onTerminalCompletionsRequested', - body: 'onTerminalCompletionsRequested', - description: nls.localize('vscode.extension.activationEvents.onTerminalCompletionsRequested', 'An activation event emitted when terminal completions are requested.'), - }, { label: 'onTerminalShellIntegration', body: 'onTerminalShellIntegration:${1:shellType}',