From 4eef1c0dfb46822807b83797cd1386c857500a44 Mon Sep 17 00:00:00 2001 From: Peng Lyu Date: Mon, 26 Aug 2019 13:36:02 -0700 Subject: [PATCH] svg is necessary in monaco. --- src/vs/editor/browser/widget/inlineDiffMargin.ts | 2 +- src/vs/editor/browser/widget/media/diffEditor.css | 11 ++++++++--- src/vs/editor/browser/widget/media/lightbulb-dark.svg | 3 +++ .../editor/browser/widget/media/lightbulb-light.svg | 4 ++++ 4 files changed, 16 insertions(+), 4 deletions(-) create mode 100644 src/vs/editor/browser/widget/media/lightbulb-dark.svg create mode 100644 src/vs/editor/browser/widget/media/lightbulb-light.svg diff --git a/src/vs/editor/browser/widget/inlineDiffMargin.ts b/src/vs/editor/browser/widget/inlineDiffMargin.ts index cd7bdfe36be..2b3b53035c2 100644 --- a/src/vs/editor/browser/widget/inlineDiffMargin.ts +++ b/src/vs/editor/browser/widget/inlineDiffMargin.ts @@ -56,7 +56,7 @@ export class InlineDiffMargin extends Disposable { this._marginDomNode.style.zIndex = '10'; this._diffActions = document.createElement('div'); - this._diffActions.className = 'octicon octicon-light-bulb'; + this._diffActions.className = 'lightbulb-glyph'; this._diffActions.style.position = 'absolute'; const lineHeight = editor.getConfiguration().lineHeight; const lineFeed = editor.getModel()!.getEOL(); diff --git a/src/vs/editor/browser/widget/media/diffEditor.css b/src/vs/editor/browser/widget/media/diffEditor.css index bb1ee7ad0b8..d1d0e48f366 100644 --- a/src/vs/editor/browser/widget/media/diffEditor.css +++ b/src/vs/editor/browser/widget/media/diffEditor.css @@ -94,10 +94,15 @@ display: inline-block; } -.monaco-editor .margin-view-zones .octicon-light-bulb { - opacity: 0.6; +.monaco-editor .margin-view-zones .inline-deleted-margin-view-zone .lightbulb-glyph { + background: url('lightbulb-light.svg') center center no-repeat; } -.monaco-editor .margin-view-zones .octicon-light-bulb:hover { +.monaco-editor.vs-dark .margin-view-zones .inline-deleted-margin-view-zone .lightbulb-glyph, +.monaco-editor.hc-dark .margin-view-zones .inline-deleted-margin-view-zone .lightbulb-glyph { + background: url('lightbulb-dark.svg') center center no-repeat; +} + +.monaco-editor .margin-view-zones .lightbulb-glyph:hover { cursor: pointer; } diff --git a/src/vs/editor/browser/widget/media/lightbulb-dark.svg b/src/vs/editor/browser/widget/media/lightbulb-dark.svg new file mode 100644 index 00000000000..5fe8931a815 --- /dev/null +++ b/src/vs/editor/browser/widget/media/lightbulb-dark.svg @@ -0,0 +1,3 @@ + + + diff --git a/src/vs/editor/browser/widget/media/lightbulb-light.svg b/src/vs/editor/browser/widget/media/lightbulb-light.svg new file mode 100644 index 00000000000..191c566fd2c --- /dev/null +++ b/src/vs/editor/browser/widget/media/lightbulb-light.svg @@ -0,0 +1,4 @@ + + + +