Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2025-12-24 20:26:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix markdown preview not cleaning up context/state on close

Browse Source 
Fixes #51033
This commit is contained in:
Matt Bierner
2018-06-07 16:38:34 -07:00
parent 26d5d76a23
commit 4f324d1712
1 changed files with 16 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
extensions/markdown-language-features/src/features/previewManager.ts
View File

@@ -116,8 +116,8 @@ export class MarkdownPreviewManager implements vscode.WebviewPanelSerializer {
this.topmostLineMonitor,
this.contributions);
vscode.commands.executeCommand('setContext', MarkdownPreviewManager.markdownPreviewActiveContextKey, true);
this.setPreviewActiveContext(true);
this.activePreview = preview;
return this.registerPreview(preview);
}
@@ -127,22 +127,29 @@ export class MarkdownPreviewManager implements vscode.WebviewPanelSerializer {
this.previews.push(preview);
preview.onDispose(() => {
const existing = this.previews.indexOf(preview!);
if (existing >= 0) {
this.previews.splice(existing, 1);
const existing = this.previews.indexOf(preview);
if (existing === -1) {
return;
}
this.previews.splice(existing, 1);
if (this.activePreview === preview) {
this.setPreviewActiveContext(false);
this.activePreview = undefined;
}
});
preview.onDidChangeViewState(({ webviewPanel }) => {
disposeAll(this.previews.filter(otherPreview => preview !== otherPreview && preview!.matches(otherPreview)));
vscode.commands.executeCommand('setContext', MarkdownPreviewManager.markdownPreviewActiveContextKey,
webviewPanel.visible);
this.setPreviewActiveContext(webviewPanel.visible);
this.activePreview = webviewPanel.visible ? preview : undefined;
});
return preview;
}
private setPreviewActiveContext(value: boolean) {
vscode.commands.executeCommand('setContext', MarkdownPreviewManager.markdownPreviewActiveContextKey, value);
}
}