Cleanup deprecated IEnvironmentService.configuration property (#141859)

* renames and reductions

* adopt for files to open, diff, wait

* remove from tests

* backup path

* accessibility support

* remove unused

* more inlines

* perf

* removal

* more cleanup

* removal of workbench config object
This commit is contained in:
Benjamin Pasero
2022-01-31 10:44:53 +01:00
committed by GitHub
parent 5323a53746
commit 4f4df625f9
23 changed files with 201 additions and 181 deletions

View File

@@ -38,11 +38,11 @@ export class TimerService extends AbstractTimerService {
@IStorageService private readonly _storageService: IStorageService
) {
super(lifecycleService, contextService, extensionService, updateService, paneCompositeService, editorService, accessibilityService, telemetryService, layoutService);
this.setPerformanceMarks('main', _environmentService.configuration.perfMarks);
this.setPerformanceMarks('main', _environmentService.window.perfMarks);
}
protected _isInitialStartup(): boolean {
return Boolean(this._environmentService.configuration.isInitialStartup);
return Boolean(this._environmentService.window.isInitialStartup);
}
protected _didUseCachedData(): boolean {
return didUseCachedData(this._productService, this._storageService, this._environmentService);
@@ -97,7 +97,7 @@ export function didUseCachedData(productService: IProductService, storageService
// this being the first start with the commit
// or subsequent
if (typeof _didUseCachedData !== 'boolean') {
if (!environmentService.configuration.codeCachePath || !productService.commit) {
if (!environmentService.window.isCodeCaching || !productService.commit) {
_didUseCachedData = false; // we only produce cached data whith commit and code cache path
} else if (storageService.get(lastRunningCommitStorageKey, StorageScope.GLOBAL) === productService.commit) {
_didUseCachedData = true; // subsequent start on same commit, assume cached data is there