Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-27 20:13:32 +01:00
Code Issues Packages Projects Releases Wiki Activity

Enforce node boundaries in places where it matters (#53192)

Browse Source 
* Enfoce node boundries in places where it matters

* Flip defualt emmet includeBoundries to true

Explicitly set getNode's include boundries where needed

* Remove defualt papameter

* Add update image boundry tests

* Add tests for bondries on some of the tag actions

* Rest of tag tests
This commit is contained in:
Jackson Kearl
2018-06-29 13:40:38 -07:00
committed by Ramya Rao
parent d8836913b4
commit 4f870afa58
11 changed files with 137 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
extensions/emmet/src/selectItemHTML.ts
View File

@@ -8,7 +8,7 @@ import { getDeepestNode, findNextWord, findPrevWord, getHtmlNode } from './util'
import { HtmlNode } from 'EmmetNode';
export function nextItemHTML(selectionStart: vscode.Position, selectionEnd: vscode.Position, editor: vscode.TextEditor, rootNode: HtmlNode): vscode.Selection | undefined {
let currentNode = getHtmlNode(editor.document, rootNode, selectionEnd);
let currentNode = getHtmlNode(editor.document, rootNode, selectionEnd, false);
let nextNode: HtmlNode | undefined = undefined;
if (!currentNode) {
@@ -54,7 +54,7 @@ export function nextItemHTML(selectionStart: vscode.Position, selectionEnd: vsco
}
export function prevItemHTML(selectionStart: vscode.Position, selectionEnd: vscode.Position, editor: vscode.TextEditor, rootNode: HtmlNode): vscode.Selection | undefined {
let currentNode = getHtmlNode(editor.document, rootNode, selectionStart);
let currentNode = getHtmlNode(editor.document, rootNode, selectionStart, false);
let prevNode: HtmlNode | undefined = undefined;
if (!currentNode) {