Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-24 10:38:59 +01:00
Code Issues Packages Projects Releases Wiki Activity

Enforce node boundaries in places where it matters (#53192)

Browse Source 
* Enfoce node boundries in places where it matters

* Flip defualt emmet includeBoundries to true

Explicitly set getNode's include boundries where needed

* Remove defualt papameter

* Add update image boundry tests

* Add tests for bondries on some of the tag actions

* Rest of tag tests
This commit is contained in:
Jackson Kearl
2018-06-29 13:40:38 -07:00
committed by Ramya Rao
parent d8836913b4
commit 4f870afa58
11 changed files with 137 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
extensions/emmet/src/updateImageSize.ts
View File

@@ -73,13 +73,13 @@ function updateImageSizeHTML(editor: TextEditor, position: Position): Promise<Te
function updateImageSizeStyleTag(editor: TextEditor, position: Position): Promise<TextEdit[] | undefined> {
const getPropertyInsiderStyleTag = (editor: TextEditor): Property | null => {
const rootNode = parseDocument(editor.document);
const currentNode = <HtmlNode>getNode(rootNode, position);
const currentNode = <HtmlNode>getNode(rootNode, position, true);
if (currentNode && currentNode.name === 'style'
&& currentNode.open.end.isBefore(position)
&& currentNode.close.start.isAfter(position)) {
let buffer = new DocumentStreamReader(editor.document, currentNode.open.end, new Range(currentNode.open.end, currentNode.close.start));
let rootNode = parseStylesheet(buffer);
const node = getNode(rootNode, position);
const node = getNode(rootNode, position, true);
return (node && node.type === 'property') ? <Property>node : null;
}
return null;