Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-24 10:38:59 +01:00
Code Issues Packages Projects Releases Wiki Activity

Rename webview.viewColumn to the more generic webview.position

Browse Source
This commit is contained in:
Matt Bierner
2018-04-12 14:25:55 -07:00
parent e16ec3c1ff
commit 4f880aaf59
3 changed files with 17 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
src/vs/workbench/api/node/extHostWebview.ts
View File

@@ -150,22 +150,22 @@ export class ExtHostWebviewPanel implements vscode.WebviewPanel {
return this._options;
}
get viewColumn(): vscode.ViewColumn {
get position(): vscode.ViewColumn {
this.assertNotDisposed();
return this._viewColumn;
}
set position(value: vscode.ViewColumn) {
this.assertNotDisposed();
this._viewColumn = value;
}
get visible(): boolean {
this.assertNotDisposed();
return this._visible;
}
set viewColumn(value: vscode.ViewColumn) {
this.assertNotDisposed();
this._viewColumn = value;
}
set active(value: boolean) {
set visible(value: boolean) {
this.assertNotDisposed();
this._visible = value;
}
@@ -244,9 +244,9 @@ export class ExtHostWebviews implements ExtHostWebviewsShape {
const panel = this.getWebviewPanel(handle);
if (panel) {
const viewColumn = typeConverters.toViewColumn(position);
if (panel.active !== active || panel.viewColumn !== viewColumn) {
panel.active = active;
panel.viewColumn = viewColumn;
if (panel.visible !== active || panel.position !== viewColumn) {
panel.visible = active;
panel.position = viewColumn;
panel.onDidChangeViewStateEmitter.fire({ webviewPanel: panel });
}
}