Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-20 00:28:52 +01:00
Code Issues Packages Projects Releases Wiki Activity

Adresses feedback inline completion API discussion.

Browse Source
This commit is contained in:
Henning Dieterichs
2022-02-09 15:30:26 +01:00
parent 4af471748f
commit 5163f619ea
3 changed files with 39 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/vs/workbench/api/common/extHostLanguageFeatures.ts
View File

@@ -1061,14 +1061,14 @@ class InlineCompletionAdapter {
return undefined;
}
const normalizedResult: vscode.InlineCompletionList = isArray(result) ? { items: result } : result;
const normalizedResult = isArray(result) ? result : result.items;
const pid = this._cache.add(normalizedResult.items);
const pid = this._cache.add(normalizedResult);
let disposableStore: DisposableStore | undefined = undefined;
return {
pid,
items: normalizedResult.items.map<extHostProtocol.IdentifiableInlineCompletion>((item, idx) => {
items: normalizedResult.map<extHostProtocol.IdentifiableInlineCompletion>((item, idx) => {
let command: languages.Command | undefined = undefined;
if (item.command) {
if (!disposableStore) {
@@ -1078,8 +1078,12 @@ class InlineCompletionAdapter {
command = this._commands.toInternal(item.command, disposableStore);
}
const insertText = item.insertText ?? item.text;
if (insertText === undefined) {
throw new Error('text or insertText must be defined');
}
return ({
text: item.text,
text: insertText,
range: item.range ? typeConvert.Range.from(item.range) : undefined,
command,
idx: idx,