From 52a80f8ad9bd1d8a4c36d656e6561f1ea5d76d7e Mon Sep 17 00:00:00 2001
From: meganrogge <megrogge@gmail.com>
Date: Tue, 13 Jul 2021 07:07:34 -0700
Subject: [PATCH] fix #128044

---
 src/vs/workbench/api/common/extHostTerminalService.ts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/vs/workbench/api/common/extHostTerminalService.ts b/src/vs/workbench/api/common/extHostTerminalService.ts
index e36e5403ee1..b82aa18d94f 100644
--- a/src/vs/workbench/api/common/extHostTerminalService.ts
+++ b/src/vs/workbench/api/common/extHostTerminalService.ts
@@ -842,11 +842,11 @@ export class WorkerExtHostTerminalService extends BaseExtHostTerminalService {
 }
 
 function asTerminalIcon(iconPath?: vscode.Uri | { light: vscode.Uri; dark: vscode.Uri } | vscode.ThemeIcon): TerminalIcon | undefined {
-	if (!iconPath) {
+	if (!iconPath || typeof iconPath === 'string') {
 		return undefined;
 	}
 
-	if (typeof iconPath === 'string' || !('id' in iconPath)) {
+	if (!('id' in iconPath)) {
 		return iconPath;
 	}