Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-28 04:23:32 +01:00
Code Issues Packages Projects Releases Wiki Activity

Mark some buffersync members readonly

Browse Source
This commit is contained in:
Matt Bierner
2017-05-16 12:48:11 -07:00
parent 8786a903f0
commit 53b18c79e7
1 changed files with 8 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
extensions/typescript/src/features/bufferSyncSupport.ts
View File

@@ -99,22 +99,21 @@ export interface Diagnostics {
const checkTscVersionSettingKey = 'check.tscVersion';
export default class BufferSyncSupport {
private client: ITypescriptServiceClient;
private readonly client: ITypescriptServiceClient;
private _validate: boolean;
private modeIds: ObjectMap<boolean>;
private readonly modeIds: Set<string>;
private diagnostics: Diagnostics;
private disposables: Disposable[] = [];
private syncedBuffers: ObjectMap<SyncedBuffer>;
private readonly disposables: Disposable[] = [];
private readonly syncedBuffers: ObjectMap<SyncedBuffer>;
private pendingDiagnostics: { [key: string]: number; };
private diagnosticDelayer: Delayer<any>;
private readonly diagnosticDelayer: Delayer<any>;
private checkGlobalTSCVersion: boolean;
constructor(client: ITypescriptServiceClient, modeIds: string[], diagnostics: Diagnostics, validate: boolean = true) {
this.client = client;
this.modeIds = Object.create(null);
modeIds.forEach(modeId => this.modeIds[modeId] = true);
this.modeIds = new Set<string>(modeIds);
this.diagnostics = diagnostics;
this._validate = validate;
@@ -124,7 +123,7 @@ export default class BufferSyncSupport {
this.syncedBuffers = Object.create(null);
const tsConfig = workspace.getConfiguration('typescript');
this.checkGlobalTSCVersion = client.checkGlobalTSCVersion && this.modeIds['typescript'] === true && tsConfig.get(checkTscVersionSettingKey, true);
this.checkGlobalTSCVersion = client.checkGlobalTSCVersion && this.modeIds.has('typescript') === true && tsConfig.get(checkTscVersionSettingKey, true);
}
public listen(): void {
@@ -163,7 +162,7 @@ export default class BufferSyncSupport {
}
private onDidOpenTextDocument(document: TextDocument): void {
if (!this.modeIds[document.languageId]) {
if (!this.modeIds.has(document.languageId)) {
return;
}
let resource = document.uri;