From 542094d306509fb79f80bded996d165df92fbcbd Mon Sep 17 00:00:00 2001 From: Sandeep Somavarapu Date: Thu, 3 Sep 2020 11:36:54 +0200 Subject: [PATCH] ignore when invalid credentials data is passed --- src/vs/code/browser/workbench/workbench.ts | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/vs/code/browser/workbench/workbench.ts b/src/vs/code/browser/workbench/workbench.ts index 6cd3fa05be5..ad5272b2232 100644 --- a/src/vs/code/browser/workbench/workbench.ts +++ b/src/vs/code/browser/workbench/workbench.ts @@ -440,7 +440,13 @@ class WindowIndicator implements IWindowIndicator { // Find credentials from DOM const credentialsElement = document.getElementById('vscode-workbench-credentials'); const credentialsElementAttribute = credentialsElement ? credentialsElement.getAttribute('data-settings') : undefined; - const credentialsProvider = new LocalStorageCredentialsProvider(credentialsElementAttribute ? JSON.parse(credentialsElementAttribute) : []); + let credentials = undefined; + if (credentialsElementAttribute) { + try { + credentials = JSON.parse(credentialsElementAttribute); + } catch (error) { /* Invalid credentials are passed. Ignore. */ } + } + const credentialsProvider = new LocalStorageCredentialsProvider(credentials || []); // Finally create workbench create(document.body, {