Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-21 09:08:53 +01:00
Code Issues Packages Projects Releases Wiki Activity

remove dedicated types for notebook and cell metadata

Browse Source
This commit is contained in:
Johannes Rieken
2021-06-01 14:50:53 +02:00
parent 6a02e8333c
commit 545b931b96
13 changed files with 55 additions and 249 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/vs/workbench/api/common/extHostNotebook.ts
View File

@@ -385,7 +385,7 @@ export class ExtHostNotebookController implements ExtHostNotebookShape {
const { provider } = this._getProviderData(viewType);
const data = await provider.openNotebook(URI.revive(uri), { backupId, untitledDocumentData: untitledDocumentData?.buffer }, token);
return {
metadata: typeConverters.NotebookDocumentMetadata.from(data.metadata),
metadata: data.metadata ?? Object.create(null),
cells: data.cells.map(typeConverters.NotebookCellData.from),
};
}
@@ -556,7 +556,7 @@ export class ExtHostNotebookController implements ExtHostNotebookShape {
}
},
viewType,
modelData.metadata ? typeConverters.NotebookDocumentMetadata.to(modelData.metadata) : new extHostTypes.NotebookDocumentMetadata(),
modelData.metadata ?? Object.create({}),
uri,
);