Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2025-12-23 19:59:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove workaround for ts infer type suggestions showing up with no quick fix

Browse Source 
This should not be needed now that we are shipping TS 3.2.2
This commit is contained in:
Matt Bierner
2018-12-06 20:09:23 -08:00
parent d2d7fec5df
commit 5562872fea
1 changed files with 1 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
extensions/typescript-language-features/src/typeScriptServiceClientHost.ts
View File

@@ -266,17 +266,7 @@ export default class TypeScriptServiceClientHost extends Disposable {
diagnostics: Proto.Diagnostic[],
source: string
): (vscode.Diagnostic & { reportUnnecessary: any })[] {
return diagnostics
.filter(tsDiag => {
// See https://github.com/Microsoft/TypeScript/issues/28702
// The infer type suggestions are being returned even when no code action is available.
// Hide these on broken versions of TS because showing them currently is very confusing.
if (tsDiag.code === 7044) {
return !(this.client.apiVersion.gte(API.v320) && this.client.apiVersion.lt(API.v330));
}
return true;
})
.map(tsDiag => this.tsDiagnosticToVsDiagnostic(tsDiag, source));
return diagnostics.map(tsDiag => this.tsDiagnosticToVsDiagnostic(tsDiag, source));
}
private tsDiagnosticToVsDiagnostic(diagnostic: Proto.Diagnostic, source: string): vscode.Diagnostic & { reportUnnecessary: any } {