From 56cedb2ba7aa338fa7789486c346288ea27fb7ba Mon Sep 17 00:00:00 2001 From: rebornix Date: Thu, 24 Sep 2020 14:26:46 -0700 Subject: [PATCH] re #103454. comments/notebook --- src/vs/workbench/contrib/comments/browser/commentNode.ts | 2 +- .../contrib/comments/browser/commentThreadWidget.ts | 4 ++-- src/vs/workbench/contrib/comments/browser/commentsView.ts | 2 +- .../notebook/browser/diff/notebookTextDiffEditor.ts | 3 +-- .../contrib/notebook/browser/notebookEditorWidget.ts | 7 +++---- .../notebook/browser/view/renderers/cellActionView.ts | 2 +- .../contrib/notebook/browser/view/renderers/codeCell.ts | 7 +++---- .../notebook/browser/view/renderers/markdownCell.ts | 4 ++-- 8 files changed, 14 insertions(+), 17 deletions(-) diff --git a/src/vs/workbench/contrib/comments/browser/commentNode.ts b/src/vs/workbench/contrib/comments/browser/commentNode.ts index 06a8cf9b42e..0a1ab70e9d6 100644 --- a/src/vs/workbench/contrib/comments/browser/commentNode.ts +++ b/src/vs/workbench/contrib/comments/browser/commentNode.ts @@ -519,7 +519,7 @@ export class CommentNode extends Disposable { focus() { this.domNode.focus(); if (!this._clearTimeout) { - dom.addClass(this.domNode, 'focus'); + this.domNode.classList.add('focus'); this._clearTimeout = setTimeout(() => { this.domNode.classList.remove('focus'); }, 3000); diff --git a/src/vs/workbench/contrib/comments/browser/commentThreadWidget.ts b/src/vs/workbench/contrib/comments/browser/commentThreadWidget.ts index f379c44b583..70e9bfcb51e 100644 --- a/src/vs/workbench/contrib/comments/browser/commentThreadWidget.ts +++ b/src/vs/workbench/contrib/comments/browser/commentThreadWidget.ts @@ -553,7 +553,7 @@ export class ReviewZoneWidget extends ZoneWidget implements ICommentThreadWidget this._commentForm.classList.remove('expand'); this._commentEditor.getDomNode()!.style.outline = ''; this._error.textContent = ''; - dom.addClass(this._error, 'hidden'); + this._error.classList.add('hidden'); } } })); @@ -708,7 +708,7 @@ export class ReviewZoneWidget extends ZoneWidget implements ICommentThreadWidget this._commentForm.classList.remove('expand'); this._commentEditor.getDomNode()!.style.outline = ''; this._error.textContent = ''; - dom.addClass(this._error, 'hidden'); + this._error.classList.add('hidden'); } private createReplyButton() { diff --git a/src/vs/workbench/contrib/comments/browser/commentsView.ts b/src/vs/workbench/contrib/comments/browser/commentsView.ts index d1a8b91f43c..026a98b0696 100644 --- a/src/vs/workbench/contrib/comments/browser/commentsView.ts +++ b/src/vs/workbench/contrib/comments/browser/commentsView.ts @@ -60,7 +60,7 @@ export class CommentsPanel extends ViewPane { public renderBody(container: HTMLElement): void { super.renderBody(container); - dom.addClass(container, 'comments-panel'); + container.classList.add('comments-panel'); let domContainer = dom.append(container, dom.$('.comments-panel-container')); this.treeContainer = dom.append(domContainer, dom.$('.tree-container')); diff --git a/src/vs/workbench/contrib/notebook/browser/diff/notebookTextDiffEditor.ts b/src/vs/workbench/contrib/notebook/browser/diff/notebookTextDiffEditor.ts index 4fa9f6575c0..883003b2a20 100644 --- a/src/vs/workbench/contrib/notebook/browser/diff/notebookTextDiffEditor.ts +++ b/src/vs/workbench/contrib/notebook/browser/diff/notebookTextDiffEditor.ts @@ -81,8 +81,7 @@ export class NotebookTextDiffEditor extends EditorPane implements INotebookTextD protected createEditor(parent: HTMLElement): void { this._rootElement = DOM.append(parent, DOM.$('.notebook-text-diff-editor')); this._overflowContainer = document.createElement('div'); - DOM.addClass(this._overflowContainer, 'notebook-overflow-widget-container'); - DOM.addClass(this._overflowContainer, 'monaco-editor'); + this._overflowContainer.classList.add('notebook-overflow-widget-container', 'monaco-editor'); DOM.append(parent, this._overflowContainer); const renderer = this.instantiationService.createInstance(CellDiffRenderer, this); diff --git a/src/vs/workbench/contrib/notebook/browser/notebookEditorWidget.ts b/src/vs/workbench/contrib/notebook/browser/notebookEditorWidget.ts index b803e39d664..df7cf772489 100644 --- a/src/vs/workbench/contrib/notebook/browser/notebookEditorWidget.ts +++ b/src/vs/workbench/contrib/notebook/browser/notebookEditorWidget.ts @@ -428,18 +428,17 @@ export class NotebookEditorWidget extends Disposable implements INotebookEditor private _createBody(parent: HTMLElement): void { this._body = document.createElement('div'); - DOM.addClass(this._body, 'cell-list-container'); + this._body.classList.add('cell-list-container'); this._createCellList(); DOM.append(parent, this._body); this._overflowContainer = document.createElement('div'); - DOM.addClass(this._overflowContainer, 'notebook-overflow-widget-container'); - DOM.addClass(this._overflowContainer, 'monaco-editor'); + this._overflowContainer.classList.add('notebook-overflow-widget-container', 'monaco-editor'); DOM.append(parent, this._overflowContainer); } private _createCellList(): void { - DOM.addClass(this._body, 'cell-list-container'); + this._body.classList.add('cell-list-container'); this._dndController = this._register(new CellDragAndDropController(this, this._body)); const getScopedContextKeyService = (container?: HTMLElement) => this._list!.contextKeyService.createScoped(container); diff --git a/src/vs/workbench/contrib/notebook/browser/view/renderers/cellActionView.ts b/src/vs/workbench/contrib/notebook/browser/view/renderers/cellActionView.ts index 66ffa090a93..55fa6e24834 100644 --- a/src/vs/workbench/contrib/notebook/browser/view/renderers/cellActionView.ts +++ b/src/vs/workbench/contrib/notebook/browser/view/renderers/cellActionView.ts @@ -23,7 +23,7 @@ export class VerticalSeparator extends Action { export class VerticalSeparatorViewItem extends BaseActionViewItem { render(container: HTMLElement) { - DOM.addClass(container, 'verticalSeparator'); + container.classList.add('verticalSeparator'); // const iconContainer = DOM.append(container, $('.verticalSeparator')); // DOM.addClasses(iconContainer, 'codicon', 'codicon-chrome-minimize'); } diff --git a/src/vs/workbench/contrib/notebook/browser/view/renderers/codeCell.ts b/src/vs/workbench/contrib/notebook/browser/view/renderers/codeCell.ts index e19e4c443a4..ca6e519dfcd 100644 --- a/src/vs/workbench/contrib/notebook/browser/view/renderers/codeCell.ts +++ b/src/vs/workbench/contrib/notebook/browser/view/renderers/codeCell.ts @@ -223,7 +223,7 @@ export class CodeCell extends Disposable { this._register(viewCell.onCellDecorationsChanged((e) => { e.added.forEach(options => { if (options.className) { - DOM.addClass(templateData.rootContainer, options.className); + templateData.rootContainer.classList.add(options.className); } if (options.outputClassName) { @@ -245,7 +245,7 @@ export class CodeCell extends Disposable { viewCell.getCellDecorations().forEach(options => { if (options.className) { - DOM.addClass(templateData.rootContainer, options.className); + templateData.rootContainer.classList.add(options.className); } if (options.outputClassName) { @@ -520,8 +520,7 @@ export class CodeCell extends Disposable { this.viewCell.selfSizeMonitoring = true; this.notebookEditor.createInset(this.viewCell, result as any, this.viewCell.getOutputOffset(index)); } else { - DOM.addClass(outputItemDiv, 'foreground'); - DOM.addClass(outputItemDiv, 'output-element'); + outputItemDiv.classList.add('foreground', 'output-element'); outputItemDiv.style.position = 'absolute'; } diff --git a/src/vs/workbench/contrib/notebook/browser/view/renderers/markdownCell.ts b/src/vs/workbench/contrib/notebook/browser/view/renderers/markdownCell.ts index 28d27b1f1d2..8265869c361 100644 --- a/src/vs/workbench/contrib/notebook/browser/view/renderers/markdownCell.ts +++ b/src/vs/workbench/contrib/notebook/browser/view/renderers/markdownCell.ts @@ -109,7 +109,7 @@ export class StatefulMarkdownCell extends Disposable { this._register(viewCell.onCellDecorationsChanged((e) => { e.added.forEach(options => { if (options.className) { - DOM.addClass(templateData.rootContainer, options.className); + templateData.rootContainer.classList.add(options.className); } }); @@ -124,7 +124,7 @@ export class StatefulMarkdownCell extends Disposable { viewCell.getCellDecorations().forEach(options => { if (options.className) { - DOM.addClass(templateData.rootContainer, options.className); + templateData.rootContainer.classList.add(options.className); } });