From 56f0349a67be832e667defce2fcbc98a053f4a28 Mon Sep 17 00:00:00 2001 From: Osvaldo Ortega Date: Mon, 9 Feb 2026 01:58:14 +0100 Subject: [PATCH] Comments --- .../browser/agentSessionsWelcome.ts | 45 +------------------ 1 file changed, 2 insertions(+), 43 deletions(-) diff --git a/src/vs/workbench/contrib/welcomeAgentSessions/browser/agentSessionsWelcome.ts b/src/vs/workbench/contrib/welcomeAgentSessions/browser/agentSessionsWelcome.ts index 223c4fb4be8..3e085c908a6 100644 --- a/src/vs/workbench/contrib/welcomeAgentSessions/browser/agentSessionsWelcome.ts +++ b/src/vs/workbench/contrib/welcomeAgentSessions/browser/agentSessionsWelcome.ts @@ -127,7 +127,6 @@ export class AgentSessionsWelcomePage extends EditorPane { private chatModelRef: IReference | undefined; private sessionsControl: AgentSessionsControl | undefined; private sessionsControlContainer: HTMLElement | undefined; - private sessionsLoadingContainer: HTMLElement | undefined; private readonly sessionsControlDisposables = this._register(new DisposableStore()); private readonly contentDisposables = this._register(new DisposableStore()); private contextService: IContextKeyService; @@ -534,7 +533,6 @@ export class AgentSessionsWelcomePage extends EditorPane { // Clear previous sessions control this.sessionsControlDisposables.clear(); this.sessionsControl = undefined; - this.sessionsLoadingContainer = undefined; const sessions = this.agentSessionsService.model.sessions.filter(s => !s.isArchived()); @@ -545,49 +543,10 @@ export class AgentSessionsWelcomePage extends EditorPane { } } - private buildLoadingSkeleton(container: HTMLElement): HTMLElement { - const loadingContainer = append(container, $('.agentSessionsWelcome-sessionsLoading', { - 'role': 'status', - 'aria-busy': 'true', - 'aria-label': localize('loadingSessions', "Loading sessions...") - })); - - // Create skeleton items to match MAX_SESSIONS (6 items, arranged in 2 columns) - for (let i = 0; i < MAX_SESSIONS; i++) { - const skeleton = append(loadingContainer, $('.agentSessionsWelcome-sessionSkeleton', { 'aria-hidden': 'true' })); - append(skeleton, $('.agentSessionsWelcome-sessionSkeleton-icon')); - const content = append(skeleton, $('.agentSessionsWelcome-sessionSkeleton-content')); - append(content, $('.agentSessionsWelcome-sessionSkeleton-title')); - append(content, $('.agentSessionsWelcome-sessionSkeleton-description')); - } - - return loadingContainer; - } - - private hideLoadingSkeleton(): void { - // Hide loading skeleton and show the sessions control - if (this.sessionsLoadingContainer) { - this.sessionsLoadingContainer.style.display = 'none'; - } - if (this.sessionsControlContainer) { - this.sessionsControlContainer.style.display = ''; - this.layoutSessionsControl(); - } - } - private buildSessionsGrid(container: HTMLElement, _sessions: IAgentSession[]): void { // Show cached sessions immediately if available, otherwise show loading skeleton - const hasCachedSessions = _sessions.length > 0; - - this.sessionsLoadingContainer = this.buildLoadingSkeleton(container); this.sessionsControlContainer = append(container, $('.agentSessionsWelcome-sessionsGrid')); - if (!hasCachedSessions) { - // Only hide the control if there are no cached sessions to show - this.sessionsControlContainer.style.display = 'none'; - } else { - this.sessionsLoadingContainer.style.display = 'none'; - } const options: IAgentSessionsControlOptions = { overrideStyles: getListStyles({ listBackground: editorBackground, @@ -615,11 +574,11 @@ export class AgentSessionsWelcomePage extends EditorPane { // Listen for loading state changes to toggle skeleton visibility this.sessionsControlDisposables.add(this.agentSessionsService.model.onDidResolve(() => { - this.hideLoadingSkeleton(); + this.layoutSessionsControl(); })); if (this.agentSessionsService.model.resolved) { - this.hideLoadingSkeleton(); + this.layoutSessionsControl(); } // Schedule layout at next animation frame to ensure proper rendering