From 579cf91f0a07f0f2b30ea37bf67f4bdc0a84c8e5 Mon Sep 17 00:00:00 2001
From: Alex Dima <alexdima@microsoft.com>
Date: Tue, 11 May 2021 14:57:50 +0200
Subject: [PATCH] Fixes microsoft/monaco-editor#2474: Use 'noopener' when
 calling window.open

---
 src/vs/base/browser/dom.ts | 20 +++++++-------------
 1 file changed, 7 insertions(+), 13 deletions(-)

diff --git a/src/vs/base/browser/dom.ts b/src/vs/base/browser/dom.ts
index e5b9492f3c0..c43adcf92bc 100644
--- a/src/vs/base/browser/dom.ts
+++ b/src/vs/base/browser/dom.ts
@@ -1186,21 +1186,15 @@ export function computeScreenAwareSize(cssPx: number): number {
  * See https://mathiasbynens.github.io/rel-noopener/
  */
 export function windowOpenNoOpener(url: string): boolean {
-	if (browser.isElectron || browser.isEdgeLegacyWebView) {
-		// In VSCode, window.open() always returns null...
-		// The same is true for a WebView (see https://github.com/microsoft/monaco-editor/issues/628)
-		// Also call directly window.open in sandboxed Electron (see https://github.com/microsoft/monaco-editor/issues/2220)
-		window.open(url);
+	// By using 'noopener' in the windowFeatures argument, the newly created window will
+	// not be able to use window.opener to reach back to the current page.
+	// See https://stackoverflow.com/a/46958731
+	// See https://developer.mozilla.org/en-US/docs/Web/API/Window/open#noopener
+	const newTab = window.open(url, '_blank', 'noopener');
+	if (newTab) {
 		return true;
-	} else {
-		let newTab = window.open();
-		if (newTab) {
-			(newTab as any).opener = null;
-			newTab.location.href = url;
-			return true;
-		}
-		return false;
 	}
+	return false;
 }
 
 export function animate(fn: () => void): IDisposable {