Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-05-02 14:31:31 +01:00
Code Issues Packages Projects Releases Wiki Activity

Adopt dom.addDisposableListener in the few places still using addListener

Browse Source
This commit is contained in:
Alex Dima
2016-02-02 18:25:46 +01:00
parent 083a56c3b1
commit 57d7b84dee
18 changed files with 152 additions and 171 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/vs/base/browser/ui/findinput/findInput.ts
View File

@@ -49,8 +49,6 @@ export class FindInput extends Widget {
private validation:IInputValidator;
private label:string;
private optionsKeyListener: () => void;
private regex:Checkbox;
private wholeWords:Checkbox;
private caseSensitive:Checkbox;
@@ -259,8 +257,7 @@ export class FindInput extends Widget {
// Arrow-Key support to navigate between options
let indexes = [this.caseSensitive.domNode, this.wholeWords.domNode, this.regex.domNode];
this.optionsKeyListener = dom.addListener(this.domNode, dom.EventType.KEY_DOWN, (e: KeyboardEvent) => {
let event = new StandardKeyboardEvent(e);
this.onkeydown(this.domNode, (event: StandardKeyboardEvent) => {
if (event.equals(CommonKeybindings.LEFT_ARROW) || event.equals(CommonKeybindings.RIGHT_ARROW) || event.equals(CommonKeybindings.ESCAPE)) {
let index = indexes.indexOf(<HTMLElement>document.activeElement);
if (index >= 0) {
@@ -315,11 +312,6 @@ export class FindInput extends Widget {
}
public dispose(): void {
if (this.optionsKeyListener) {
this.optionsKeyListener();
this.optionsKeyListener = null;
}
super.dispose();
}
}