Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-27 03:54:24 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix what an empty string is, don't render empty MarkdownString, #29076

Browse Source
This commit is contained in:
Johannes Rieken
2017-08-24 16:49:21 +02:00
parent fb83608ebc
commit 57da808a98
2 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/vs/base/common/htmlContent.ts
View File

@@ -17,7 +17,7 @@ export class MarkdownString implements IMarkdownString {
static isEmpty(oneOrMany: IMarkdownString | IMarkdownString[]): boolean {
if (MarkdownString.isMarkdownString(oneOrMany)) {
return Boolean(oneOrMany.value);
return !oneOrMany.value;
} else if (Array.isArray(oneOrMany)) {
return oneOrMany.every(MarkdownString.isEmpty);
} else {
@@ -49,11 +49,11 @@ export class MarkdownString implements IMarkdownString {
}
appendCodeblock(langId: string, code: string): this {
this.value += '```';
this.value += '\n```';
this.value += langId;
this.value += '\n';
this.value += code;
this.value += '```\n';
this.value += '\n```\n';
return this;
}
}