diff --git a/src/vs/workbench/api/node/extHost.api.impl.ts b/src/vs/workbench/api/node/extHost.api.impl.ts index 97df467eac9..99df30ba635 100644 --- a/src/vs/workbench/api/node/extHost.api.impl.ts +++ b/src/vs/workbench/api/node/extHost.api.impl.ts @@ -265,10 +265,10 @@ export function createApiFactory( getDiagnostics: (resource?: vscode.Uri) => { return extHostDiagnostics.getDiagnostics(resource); }, - getLanguages(): TPromise { + getLanguages(): Thenable { return extHostLanguages.getLanguages(); }, - changeLanguage(document: vscode.TextDocument, languageId: string): TPromise { + changeLanguage(document: vscode.TextDocument, languageId: string): Thenable { checkProposedApiEnabled(extension); return extHostLanguages.changeLanguage(document.uri, languageId); }, @@ -351,7 +351,7 @@ export function createApiFactory( get terminals() { return extHostTerminalService.terminals; }, - showTextDocument(documentOrUri: vscode.TextDocument | vscode.Uri, columnOrOptions?: vscode.ViewColumn | vscode.TextDocumentShowOptions, preserveFocus?: boolean): TPromise { + showTextDocument(documentOrUri: vscode.TextDocument | vscode.Uri, columnOrOptions?: vscode.ViewColumn | vscode.TextDocumentShowOptions, preserveFocus?: boolean): Thenable { let documentPromise: TPromise; if (URI.isUri(documentOrUri)) { documentPromise = TPromise.wrap(workspace.openTextDocument(documentOrUri)); @@ -527,7 +527,7 @@ export function createApiFactory( saveAll: (includeUntitled?) => { return extHostWorkspace.saveAll(includeUntitled); }, - applyEdit(edit: vscode.WorkspaceEdit): TPromise { + applyEdit(edit: vscode.WorkspaceEdit): Thenable { return extHostEditors.applyWorkspaceEdit(edit); }, createFileSystemWatcher: (pattern, ignoreCreate, ignoreChange, ignoreDelete): vscode.FileSystemWatcher => { @@ -540,7 +540,7 @@ export function createApiFactory( throw errors.readonly(); }, openTextDocument(uriOrFileNameOrOptions?: vscode.Uri | string | { language?: string; content?: string; }) { - let uriPromise: TPromise; + let uriPromise: Thenable; let options = uriOrFileNameOrOptions as { language?: string; content?: string; }; if (typeof uriOrFileNameOrOptions === 'string') { diff --git a/src/vs/workbench/api/node/extHost.protocol.ts b/src/vs/workbench/api/node/extHost.protocol.ts index 4cf844d61ef..7e5e959209c 100644 --- a/src/vs/workbench/api/node/extHost.protocol.ts +++ b/src/vs/workbench/api/node/extHost.protocol.ts @@ -104,8 +104,8 @@ export interface MainThreadCommentsShape extends IDisposable { } export interface MainThreadConfigurationShape extends IDisposable { - $updateConfigurationOption(target: ConfigurationTarget, key: string, value: any, resource: UriComponents): TPromise; - $removeConfigurationOption(target: ConfigurationTarget, key: string, resource: UriComponents): TPromise; + $updateConfigurationOption(target: ConfigurationTarget, key: string, value: any, resource: UriComponents): Thenable; + $removeConfigurationOption(target: ConfigurationTarget, key: string, resource: UriComponents): Thenable; } export interface MainThreadDiagnosticsShape extends IDisposable { @@ -146,9 +146,9 @@ export interface MainThreadDocumentContentProvidersShape extends IDisposable { } export interface MainThreadDocumentsShape extends IDisposable { - $tryCreateDocument(options?: { language?: string; content?: string; }): TPromise; - $tryOpenDocument(uri: UriComponents): TPromise; - $trySaveDocument(uri: UriComponents): TPromise; + $tryCreateDocument(options?: { language?: string; content?: string; }): Thenable; + $tryOpenDocument(uri: UriComponents): Thenable; + $trySaveDocument(uri: UriComponents): Thenable; } export interface ITextEditorConfigurationUpdate { @@ -189,26 +189,26 @@ export interface ITextDocumentShowOptions { } export interface MainThreadTextEditorsShape extends IDisposable { - $tryShowTextDocument(resource: UriComponents, options: ITextDocumentShowOptions): TPromise; + $tryShowTextDocument(resource: UriComponents, options: ITextDocumentShowOptions): Thenable; $registerTextEditorDecorationType(key: string, options: editorCommon.IDecorationRenderOptions): void; $removeTextEditorDecorationType(key: string): void; - $tryShowEditor(id: string, position: EditorViewColumn): TPromise; - $tryHideEditor(id: string): TPromise; - $trySetOptions(id: string, options: ITextEditorConfigurationUpdate): TPromise; - $trySetDecorations(id: string, key: string, ranges: editorCommon.IDecorationOptions[]): TPromise; - $trySetDecorationsFast(id: string, key: string, ranges: number[]): TPromise; - $tryRevealRange(id: string, range: IRange, revealType: TextEditorRevealType): TPromise; - $trySetSelections(id: string, selections: ISelection[]): TPromise; - $tryApplyEdits(id: string, modelVersionId: number, edits: ISingleEditOperation[], opts: IApplyEditsOptions): TPromise; - $tryApplyWorkspaceEdit(workspaceEditDto: WorkspaceEditDto): TPromise; - $tryInsertSnippet(id: string, template: string, selections: IRange[], opts: IUndoStopOptions): TPromise; - $getDiffInformation(id: string): TPromise; + $tryShowEditor(id: string, position: EditorViewColumn): Thenable; + $tryHideEditor(id: string): Thenable; + $trySetOptions(id: string, options: ITextEditorConfigurationUpdate): Thenable; + $trySetDecorations(id: string, key: string, ranges: editorCommon.IDecorationOptions[]): Thenable; + $trySetDecorationsFast(id: string, key: string, ranges: number[]): Thenable; + $tryRevealRange(id: string, range: IRange, revealType: TextEditorRevealType): Thenable; + $trySetSelections(id: string, selections: ISelection[]): Thenable; + $tryApplyEdits(id: string, modelVersionId: number, edits: ISingleEditOperation[], opts: IApplyEditsOptions): Thenable; + $tryApplyWorkspaceEdit(workspaceEditDto: WorkspaceEditDto): Thenable; + $tryInsertSnippet(id: string, template: string, selections: IRange[], opts: IUndoStopOptions): Thenable; + $getDiffInformation(id: string): Thenable; } export interface MainThreadTreeViewsShape extends IDisposable { $registerTreeViewDataProvider(treeViewId: string): void; $refresh(treeViewId: string, itemsToRefresh?: { [treeItemHandle: string]: ITreeItem }): TPromise; - $reveal(treeViewId: string, treeItem: ITreeItem, parentChain: ITreeItem[], options: { select: boolean, focus: boolean }): TPromise; + $reveal(treeViewId: string, treeItem: ITreeItem, parentChain: ITreeItem[], options: { select: boolean, focus: boolean }): Thenable; } export interface MainThreadErrorsShape extends IDisposable { @@ -288,8 +288,8 @@ export interface MainThreadLanguageFeaturesShape extends IDisposable { } export interface MainThreadLanguagesShape extends IDisposable { - $getLanguages(): TPromise; - $changeLanguage(resource: UriComponents, languageId: string): TPromise; + $getLanguages(): Thenable; + $changeLanguage(resource: UriComponents, languageId: string): Thenable; } export interface MainThreadMessageOptions { @@ -302,12 +302,12 @@ export interface MainThreadMessageServiceShape extends IDisposable { } export interface MainThreadOutputServiceShape extends IDisposable { - $register(channelId: string, label: string, file?: UriComponents): TPromise; - $append(channelId: string, value: string): TPromise; - $clear(channelId: string): TPromise; - $reveal(channelId: string, preserveFocus: boolean): TPromise; - $close(channelId: string): TPromise; - $dispose(channelId: string): TPromise; + $register(channelId: string, label: string, file?: UriComponents): Thenable; + $append(channelId: string, value: string): Thenable; + $clear(channelId: string): Thenable; + $reveal(channelId: string, preserveFocus: boolean): Thenable; + $close(channelId: string): Thenable; + $dispose(channelId: string): Thenable; } export interface MainThreadProgressShape extends IDisposable { @@ -318,8 +318,8 @@ export interface MainThreadProgressShape extends IDisposable { } export interface MainThreadTerminalServiceShape extends IDisposable { - $createTerminal(name?: string, shellPath?: string, shellArgs?: string[], cwd?: string, env?: { [key: string]: string }, waitOnExit?: boolean): TPromise; - $createTerminalRenderer(name: string): TPromise; + $createTerminal(name?: string, shellPath?: string, shellArgs?: string[], cwd?: string, env?: { [key: string]: string }, waitOnExit?: boolean): Thenable; + $createTerminalRenderer(name: string): Thenable; $dispose(terminalId: number): void; $hide(terminalId: number): void; $sendText(terminalId: number, text: string, addNewLine: boolean): void; @@ -405,12 +405,12 @@ export interface TransferInputBox extends BaseTransferQuickInput { } export interface MainThreadQuickOpenShape extends IDisposable { - $show(options: IPickOptions): TPromise; - $setItems(items: TransferQuickPickItems[]): TPromise; - $setError(error: Error): TPromise; + $show(options: IPickOptions): Thenable; + $setItems(items: TransferQuickPickItems[]): Thenable; + $setError(error: Error): Thenable; $input(options: vscode.InputBoxOptions, validateInput: boolean): TPromise; - $createOrUpdate(params: TransferQuickInput): TPromise; - $dispose(id: number): TPromise; + $createOrUpdate(params: TransferQuickInput): Thenable; + $dispose(id: number): Thenable; } export interface MainThreadStatusBarShape extends IDisposable { @@ -419,8 +419,8 @@ export interface MainThreadStatusBarShape extends IDisposable { } export interface MainThreadStorageShape extends IDisposable { - $getValue(shared: boolean, key: string): TPromise; - $setValue(shared: boolean, key: string, value: any): TPromise; + $getValue(shared: boolean, key: string): Thenable; + $setValue(shared: boolean, key: string, value: any): Thenable; } export interface MainThreadTelemetryShape extends IDisposable { @@ -462,8 +462,8 @@ export interface ExtHostWebviewsShape { } export interface MainThreadUrlsShape extends IDisposable { - $registerUriHandler(handle: number, extensionId: string): TPromise; - $unregisterUriHandler(handle: number): TPromise; + $registerUriHandler(handle: number, extensionId: string): Thenable; + $unregisterUriHandler(handle: number): Thenable; } export interface ExtHostUrlsShape { @@ -472,8 +472,8 @@ export interface ExtHostUrlsShape { export interface MainThreadWorkspaceShape extends IDisposable { $startFileSearch(includePattern: string, includeFolder: string, excludePatternOrDisregardExcludes: string | false, maxResults: number, requestId: number): Thenable; - $startTextSearch(query: IPatternInfo, options: IQueryOptions, requestId: number): TPromise; - $checkExists(query: ISearchQuery, requestId: number): TPromise; + $startTextSearch(query: IPatternInfo, options: IQueryOptions, requestId: number): Thenable; + $checkExists(query: ISearchQuery, requestId: number): Thenable; $cancelSearch(requestId: number): Thenable; $saveAll(includeUntitled?: boolean): Thenable; $updateWorkspaceFolders(extensionName: string, index: number, deleteCount: number, workspaceFoldersToAdd: { uri: UriComponents, name?: string }[]): Thenable; @@ -502,11 +502,11 @@ export interface MainThreadSearchShape extends IDisposable { } export interface MainThreadTaskShape extends IDisposable { - $registerTaskProvider(handle: number): TPromise; - $unregisterTaskProvider(handle: number): TPromise; - $fetchTasks(filter?: TaskFilterDTO): TPromise; - $executeTask(task: TaskHandleDTO | TaskDTO): TPromise; - $terminateTask(id: string): TPromise; + $registerTaskProvider(handle: number): Thenable; + $unregisterTaskProvider(handle: number): Thenable; + $fetchTasks(filter?: TaskFilterDTO): Thenable; + $executeTask(task: TaskHandleDTO | TaskDTO): Thenable; + $terminateTask(id: string): Thenable; $registerTaskSystem(scheme: string, info: TaskSystemInfoDTO): void; } @@ -578,18 +578,18 @@ export interface MainThreadDebugServiceShape extends IDisposable { $acceptDAMessage(handle: number, message: DebugProtocol.ProtocolMessage): void; $acceptDAError(handle: number, name: string, message: string, stack: string): void; $acceptDAExit(handle: number, code: number, signal: string): void; - $registerDebugConfigurationProvider(type: string, hasProvideMethod: boolean, hasResolveMethod: boolean, hasDebugAdapterExecutable: boolean, handle: number): TPromise; - $unregisterDebugConfigurationProvider(handle: number): TPromise; - $startDebugging(folder: UriComponents | undefined, nameOrConfig: string | vscode.DebugConfiguration): TPromise; - $customDebugAdapterRequest(id: DebugSessionUUID, command: string, args: any): TPromise; - $appendDebugConsole(value: string): TPromise; - $startBreakpointEvents(): TPromise; - $registerBreakpoints(breakpoints: (ISourceMultiBreakpointDto | IFunctionBreakpointDto)[]): TPromise; - $unregisterBreakpoints(breakpointIds: string[], functionBreakpointIds: string[]): TPromise; + $registerDebugConfigurationProvider(type: string, hasProvideMethod: boolean, hasResolveMethod: boolean, hasDebugAdapterExecutable: boolean, handle: number): Thenable; + $unregisterDebugConfigurationProvider(handle: number): Thenable; + $startDebugging(folder: UriComponents | undefined, nameOrConfig: string | vscode.DebugConfiguration): Thenable; + $customDebugAdapterRequest(id: DebugSessionUUID, command: string, args: any): Thenable; + $appendDebugConsole(value: string): Thenable; + $startBreakpointEvents(): Thenable; + $registerBreakpoints(breakpoints: (ISourceMultiBreakpointDto | IFunctionBreakpointDto)[]): Thenable; + $unregisterBreakpoints(breakpointIds: string[], functionBreakpointIds: string[]): Thenable; } export interface MainThreadWindowShape extends IDisposable { - $getWindowVisibility(): TPromise; + $getWindowVisibility(): Thenable; } // -- extension host @@ -704,7 +704,7 @@ export interface ExtHostSearchShape { } export interface ExtHostExtensionServiceShape { - $activateByEvent(activationEvent: string): TPromise; + $activateByEvent(activationEvent: string): Thenable; } export interface FileSystemEvents { @@ -889,10 +889,10 @@ export interface ExtHostTerminalServiceShape { export interface ExtHostSCMShape { $provideOriginalResource(sourceControlHandle: number, uri: UriComponents): TPromise; - $onInputBoxValueChange(sourceControlHandle: number, value: string): TPromise; + $onInputBoxValueChange(sourceControlHandle: number, value: string): Thenable; $executeResourceCommand(sourceControlHandle: number, groupHandle: number, handle: number): TPromise; $validateInput(sourceControlHandle: number, value: string, cursorPosition: number): TPromise<[string, number] | undefined>; - $setSelectedSourceControls(selectedSourceControlHandles: number[]): TPromise; + $setSelectedSourceControls(selectedSourceControlHandles: number[]): Thenable; } export interface ExtHostTaskShape { @@ -950,7 +950,7 @@ export interface ExtHostDebugServiceShape { $runInTerminal(args: DebugProtocol.RunInTerminalRequestArguments, config: ITerminalSettings): TPromise; $startDASession(handle: number, debugType: string, adapterExecutableInfo: IAdapterExecutable | null, debugPort: number): TPromise; $stopDASession(handle: number): TPromise; - $sendDAMessage(handle: number, message: DebugProtocol.ProtocolMessage): TPromise; + $sendDAMessage(handle: number, message: DebugProtocol.ProtocolMessage): void; $resolveDebugConfiguration(handle: number, folder: UriComponents | undefined, debugConfiguration: IConfig): TPromise; $provideDebugConfigurations(handle: number, folder: UriComponents | undefined): TPromise; $debugAdapterExecutable(handle: number, folder: UriComponents | undefined): TPromise; @@ -972,7 +972,7 @@ export type DecorationData = [number, boolean, string, string, ThemeColor, strin export type DecorationReply = { [id: number]: DecorationData }; export interface ExtHostDecorationsShape { - $provideDecorations(requests: DecorationRequest[]): TPromise; + $provideDecorations(requests: DecorationRequest[]): Thenable; } export interface ExtHostWindowShape { @@ -988,10 +988,10 @@ export interface ExtHostProgressShape { } export interface ExtHostCommentsShape { - $provideDocumentComments(handle: number, document: UriComponents): TPromise; - $createNewCommentThread?(handle: number, document: UriComponents, range: IRange, text: string): TPromise; - $replyToCommentThread?(handle: number, document: UriComponents, range: IRange, commentThread: modes.CommentThread, text: string): TPromise; - $provideWorkspaceComments(handle: number): TPromise; + $provideDocumentComments(handle: number, document: UriComponents): Thenable; + $createNewCommentThread?(handle: number, document: UriComponents, range: IRange, text: string): Thenable; + $replyToCommentThread?(handle: number, document: UriComponents, range: IRange, commentThread: modes.CommentThread, text: string): Thenable; + $provideWorkspaceComments(handle: number): Thenable; } // --- proxy identifiers diff --git a/src/vs/workbench/api/node/extHostDebugService.ts b/src/vs/workbench/api/node/extHostDebugService.ts index 9a9636d1d9f..af5f5da7758 100644 --- a/src/vs/workbench/api/node/extHostDebugService.ts +++ b/src/vs/workbench/api/node/extHostDebugService.ts @@ -335,7 +335,7 @@ export class ExtHostDebugService implements ExtHostDebugServiceShape { this.fireBreakpointChanges(a, r, c); } - public addBreakpoints(breakpoints0: vscode.Breakpoint[]): TPromise { + public addBreakpoints(breakpoints0: vscode.Breakpoint[]): Thenable { this.startBreakpoints(); @@ -401,7 +401,7 @@ export class ExtHostDebugService implements ExtHostDebugServiceShape { return this._debugServiceProxy.$registerBreakpoints(dtos); } - public removeBreakpoints(breakpoints0: vscode.Breakpoint[]): TPromise { + public removeBreakpoints(breakpoints0: vscode.Breakpoint[]): Thenable { this.startBreakpoints(); @@ -484,7 +484,7 @@ export class ExtHostDebugService implements ExtHostDebugServiceShape { return asWinJsPromise(token => handler.debugAdapterExecutable(this.getFolder(folderUri), token)); } - public startDebugging(folder: vscode.WorkspaceFolder | undefined, nameOrConfig: string | vscode.DebugConfiguration): TPromise { + public startDebugging(folder: vscode.WorkspaceFolder | undefined, nameOrConfig: string | vscode.DebugConfiguration): Thenable { return this._debugServiceProxy.$startDebugging(folder ? folder.uri : undefined, nameOrConfig); } diff --git a/src/vs/workbench/api/node/extHostDocumentData.ts b/src/vs/workbench/api/node/extHostDocumentData.ts index d9daf00ff97..fec31cda756 100644 --- a/src/vs/workbench/api/node/extHostDocumentData.ts +++ b/src/vs/workbench/api/node/extHostDocumentData.ts @@ -99,7 +99,7 @@ export class ExtHostDocumentData extends MirrorTextModel { this._isDirty = isDirty; } - private _save(): TPromise { + private _save(): Thenable { if (this._isDisposed) { return TPromise.wrapError(new Error('Document has been closed')); } diff --git a/src/vs/workbench/api/node/extHostDocuments.ts b/src/vs/workbench/api/node/extHostDocuments.ts index b248ee766f2..53303a27602 100644 --- a/src/vs/workbench/api/node/extHostDocuments.ts +++ b/src/vs/workbench/api/node/extHostDocuments.ts @@ -30,7 +30,7 @@ export class ExtHostDocuments implements ExtHostDocumentsShape { private _toDispose: IDisposable[]; private _proxy: MainThreadDocumentsShape; private _documentsAndEditors: ExtHostDocumentsAndEditors; - private _documentLoader = new Map>(); + private _documentLoader = new Map>(); constructor(mainContext: IMainContext, documentsAndEditors: ExtHostDocumentsAndEditors) { this._proxy = mainContext.getProxy(MainContext.MainThreadDocuments); @@ -69,7 +69,7 @@ export class ExtHostDocuments implements ExtHostDocumentsShape { return undefined; } - public ensureDocumentData(uri: URI): TPromise { + public ensureDocumentData(uri: URI): Thenable { let cached = this._documentsAndEditors.getDocument(uri.toString()); if (cached) { @@ -91,7 +91,7 @@ export class ExtHostDocuments implements ExtHostDocumentsShape { return promise; } - public createDocumentData(options?: { language?: string; content?: string }): TPromise { + public createDocumentData(options?: { language?: string; content?: string }): Thenable { return this._proxy.$tryCreateDocument(options).then(data => URI.revive(data)); } diff --git a/src/vs/workbench/api/node/extHostExtensionService.ts b/src/vs/workbench/api/node/extHostExtensionService.ts index 47955f26064..92b27d28277 100644 --- a/src/vs/workbench/api/node/extHostExtensionService.ts +++ b/src/vs/workbench/api/node/extHostExtensionService.ts @@ -29,7 +29,7 @@ class ExtensionMemento implements IExtensionMemento { private readonly _shared: boolean; private readonly _storage: ExtHostStorage; - private readonly _init: TPromise; + private readonly _init: Thenable; private _value: { [n: string]: any; }; constructor(id: string, global: boolean, storage: ExtHostStorage) { @@ -43,7 +43,7 @@ class ExtensionMemento implements IExtensionMemento { }); } - get whenReady(): TPromise { + get whenReady(): Thenable { return this._init; } diff --git a/src/vs/workbench/api/node/extHostLanguages.ts b/src/vs/workbench/api/node/extHostLanguages.ts index 9ad497bbd92..f8dac71a3b3 100644 --- a/src/vs/workbench/api/node/extHostLanguages.ts +++ b/src/vs/workbench/api/node/extHostLanguages.ts @@ -4,7 +4,6 @@ *--------------------------------------------------------------------------------------------*/ 'use strict'; -import { TPromise } from 'vs/base/common/winjs.base'; import { MainContext, MainThreadLanguagesShape, IMainContext } from './extHost.protocol'; import * as vscode from 'vscode'; @@ -18,10 +17,10 @@ export class ExtHostLanguages { this._proxy = mainContext.getProxy(MainContext.MainThreadLanguages); } - getLanguages(): TPromise { + getLanguages(): Thenable { return this._proxy.$getLanguages(); } - changeLanguage(documentUri: vscode.Uri, languageId: string): TPromise { + changeLanguage(documentUri: vscode.Uri, languageId: string): Thenable { return this._proxy.$changeLanguage(documentUri, languageId); } } diff --git a/src/vs/workbench/api/node/extHostOutputService.ts b/src/vs/workbench/api/node/extHostOutputService.ts index 90a947e1696..23bc0b07793 100644 --- a/src/vs/workbench/api/node/extHostOutputService.ts +++ b/src/vs/workbench/api/node/extHostOutputService.ts @@ -18,7 +18,7 @@ export abstract class AbstractExtHostOutputChannel implements vscode.OutputChann protected readonly _id: string; private readonly _name: string; protected readonly _proxy: MainThreadOutputServiceShape; - protected _registerationPromise: TPromise = TPromise.as(null); + protected _registerationPromise: Thenable = TPromise.as(null); private _disposed: boolean; constructor(name: string, proxy: MainThreadOutputServiceShape) { diff --git a/src/vs/workbench/api/node/extHostStorage.ts b/src/vs/workbench/api/node/extHostStorage.ts index 5a36bd5d550..534d5ef0c14 100644 --- a/src/vs/workbench/api/node/extHostStorage.ts +++ b/src/vs/workbench/api/node/extHostStorage.ts @@ -4,7 +4,6 @@ *--------------------------------------------------------------------------------------------*/ 'use strict'; -import { TPromise } from 'vs/base/common/winjs.base'; import { MainContext, MainThreadStorageShape, IMainContext } from './extHost.protocol'; export class ExtHostStorage { @@ -15,11 +14,11 @@ export class ExtHostStorage { this._proxy = mainContext.getProxy(MainContext.MainThreadStorage); } - getValue(shared: boolean, key: string, defaultValue?: T): TPromise { + getValue(shared: boolean, key: string, defaultValue?: T): Thenable { return this._proxy.$getValue(shared, key).then(value => value || defaultValue); } - setValue(shared: boolean, key: string, value: any): TPromise { + setValue(shared: boolean, key: string, value: any): Thenable { return this._proxy.$setValue(shared, key, value); } } diff --git a/src/vs/workbench/api/node/extHostTask.ts b/src/vs/workbench/api/node/extHostTask.ts index 6377129af1f..450ec6e935e 100644 --- a/src/vs/workbench/api/node/extHostTask.ts +++ b/src/vs/workbench/api/node/extHostTask.ts @@ -803,7 +803,7 @@ export class ExtHostTask implements ExtHostTaskShape { return result; } - public terminateTask(execution: vscode.TaskExecution): TPromise { + public terminateTask(execution: vscode.TaskExecution): Thenable { if (!(execution instanceof TaskExecutionImpl)) { throw new Error('No valid task execution provided'); } diff --git a/src/vs/workbench/api/node/extHostTextEditor.ts b/src/vs/workbench/api/node/extHostTextEditor.ts index 5be78409cb1..5131242cf21 100644 --- a/src/vs/workbench/api/node/extHostTextEditor.ts +++ b/src/vs/workbench/api/node/extHostTextEditor.ts @@ -485,7 +485,7 @@ export class ExtHostTextEditor implements vscode.TextEditor { ); } - private _trySetSelection(): TPromise { + private _trySetSelection(): Thenable { let selection = this._selections.map(TypeConverters.Selection.from); return this._runOnProxy(() => this._proxy.$trySetSelections(this._id, selection)); } @@ -506,7 +506,7 @@ export class ExtHostTextEditor implements vscode.TextEditor { return this._applyEdit(edit); } - private _applyEdit(editBuilder: TextEditorEdit): TPromise { + private _applyEdit(editBuilder: TextEditorEdit): Thenable { let editData = editBuilder.finalize(); // return when there is nothing to do @@ -592,7 +592,7 @@ export class ExtHostTextEditor implements vscode.TextEditor { // ---- util - private _runOnProxy(callback: () => TPromise): TPromise { + private _runOnProxy(callback: () => Thenable): Thenable { if (this._disposed) { console.warn('TextEditor is closed/disposed'); return TPromise.as(undefined); @@ -606,7 +606,7 @@ export class ExtHostTextEditor implements vscode.TextEditor { } } -function warnOnError(promise: TPromise): void { +function warnOnError(promise: Thenable): void { promise.then(null, (err) => { console.warn(err); }); diff --git a/src/vs/workbench/api/node/extHostTextEditors.ts b/src/vs/workbench/api/node/extHostTextEditors.ts index fb33f6247fa..d1c332244af 100644 --- a/src/vs/workbench/api/node/extHostTextEditors.ts +++ b/src/vs/workbench/api/node/extHostTextEditors.ts @@ -6,7 +6,6 @@ import { Event, Emitter } from 'vs/base/common/event'; import { toThenable } from 'vs/base/common/async'; -import { TPromise } from 'vs/base/common/winjs.base'; import { TextEditorSelectionChangeKind } from './extHostTypes'; import * as TypeConverters from './extHostTypeConverters'; import { TextEditorDecorationType, ExtHostTextEditor } from './extHostTextEditor'; @@ -53,10 +52,10 @@ export class ExtHostEditors implements ExtHostEditorsShape { return this._extHostDocumentsAndEditors.allEditors(); } - showTextDocument(document: vscode.TextDocument, column: vscode.ViewColumn, preserveFocus: boolean): TPromise; - showTextDocument(document: vscode.TextDocument, options: { column: vscode.ViewColumn, preserveFocus: boolean, pinned: boolean }): TPromise; - showTextDocument(document: vscode.TextDocument, columnOrOptions: vscode.ViewColumn | vscode.TextDocumentShowOptions, preserveFocus?: boolean): TPromise; - showTextDocument(document: vscode.TextDocument, columnOrOptions: vscode.ViewColumn | vscode.TextDocumentShowOptions, preserveFocus?: boolean): TPromise { + showTextDocument(document: vscode.TextDocument, column: vscode.ViewColumn, preserveFocus: boolean): Thenable; + showTextDocument(document: vscode.TextDocument, options: { column: vscode.ViewColumn, preserveFocus: boolean, pinned: boolean }): Thenable; + showTextDocument(document: vscode.TextDocument, columnOrOptions: vscode.ViewColumn | vscode.TextDocumentShowOptions, preserveFocus?: boolean): Thenable; + showTextDocument(document: vscode.TextDocument, columnOrOptions: vscode.ViewColumn | vscode.TextDocumentShowOptions, preserveFocus?: boolean): Thenable { let options: ITextDocumentShowOptions; if (typeof columnOrOptions === 'number') { options = { @@ -90,7 +89,7 @@ export class ExtHostEditors implements ExtHostEditorsShape { return new TextEditorDecorationType(this._proxy, options); } - applyWorkspaceEdit(edit: vscode.WorkspaceEdit): TPromise { + applyWorkspaceEdit(edit: vscode.WorkspaceEdit): Thenable { const dto = TypeConverters.WorkspaceEdit.from(edit, this._extHostDocumentsAndEditors); return this._proxy.$tryApplyWorkspaceEdit(dto); }