Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-20 16:49:06 +01:00
Code Issues Packages Projects Releases Wiki Activity

Use readonly for cache

Browse Source 
This type never modifies the input arrays
This commit is contained in:
Matt Bierner
2019-06-13 16:43:09 -07:00
parent 89aadaa131
commit 592b91b5cb
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/vs/workbench/api/common/extHostLanguageFeatures.ts
View File

@@ -810,10 +810,10 @@ class SignatureHelpAdapter {
class Cache<T> {
private _data = new Map<number, T[]>();
private _data = new Map<number, readonly T[]>();
private _idPool = 1;
add(item: T[]): number {
add(item: readonly T[]): number {
const id = this._idPool++;
this._data.set(id, item);
return id;
@@ -898,7 +898,7 @@ class ColorProviderAdapter {
provideColors(resource: URI, token: CancellationToken): Promise<IRawColorInfo[]> {
const doc = this._documents.getDocument(resource);
return asPromise(() => this._provider.provideDocumentColors(doc, token)).then(colors => {
if (!Array.isArray(colors)) {
if (!Array.isArray<vscode.ColorInformation>(colors)) {
return [];
}