Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-23 01:58:53 +01:00
Code Issues Packages Projects Releases Wiki Activity

Improve markdown link regexp (#152533)

Browse Source 
* Improve markdown link regexp

This makes the markdown link regexp more readable and also combines the two regular expressions we were running

* Fixed backtracking
This commit is contained in:
Matt Bierner
2022-06-18 21:25:54 -07:00
committed by GitHub
parent 5ffcfde11d
commit 5a175207de
2 changed files with 45 additions and 39 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
extensions/markdown-language-features/src/test/documentLinkProvider.test.ts
View File

@@ -32,7 +32,7 @@ function assertLinksEqual(actualLinks: readonly vscode.DocumentLink[], expectedR
}
}
suite('markdown.DocumentLinkProvider', () => {
suite('Markdown: DocumentLinkProvider', () => {
test('Should not return anything for empty document', async () => {
const links = await getLinksForFile('');
assert.strictEqual(links.length, 0);
@@ -131,24 +131,24 @@ suite('markdown.DocumentLinkProvider', () => {
{
const links = await getLinksForFile('[![alt text](image.jpg)](https://example.com)');
assertLinksEqual(links, [
new vscode.Range(0, 25, 0, 44),
new vscode.Range(0, 13, 0, 22),
new vscode.Range(0, 25, 0, 44)
]);
}
{
const links = await getLinksForFile('[![a]( whitespace.jpg )]( https://whitespace.com )');
assertLinksEqual(links, [
new vscode.Range(0, 26, 0, 48),
new vscode.Range(0, 7, 0, 21),
new vscode.Range(0, 26, 0, 48)
]);
}
{
const links = await getLinksForFile('[![a](img1.jpg)](file1.txt) text [![a](img2.jpg)](file2.txt)');
assertLinksEqual(links, [
new vscode.Range(0, 6, 0, 14),
new vscode.Range(0, 17, 0, 26),
new vscode.Range(0, 39, 0, 47),
new vscode.Range(0, 6, 0, 14),
new vscode.Range(0, 50, 0, 59),
new vscode.Range(0, 39, 0, 47),
]);
}
});