Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-26 03:29:00 +01:00
Code Issues Packages Projects Releases Wiki Activity

Extract SupportedCodeActionProvider into own class

Browse Source
This commit is contained in:
Matt Bierner
2018-01-04 11:12:03 -08:00
parent fadbc9c6cb
commit 5a2a6c1e2e
1 changed files with 33 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

56
extensions/typescript/src/features/quickFixProvider.ts
View File

@@ -31,15 +31,46 @@ class ApplyCodeActionCommand implements Command {
}
}
export default class TypeScriptQuickFixProvider implements vscode.CodeActionProvider {
class SupportedCodeActionProvider {
private _supportedCodeActions?: Thenable<NumberSet>;
public constructor(
private readonly client: ITypeScriptServiceClient
) { }
public async getSupportedActionsForContext(context: vscode.CodeActionContext): Promise<Set<number>> {
const supportedActions = await this.supportedCodeActions;
return new Set(context.diagnostics
.map(diagnostic => +diagnostic.code)
.filter(code => supportedActions[code]));
}
private get supportedCodeActions(): Thenable<NumberSet> {
if (!this._supportedCodeActions) {
this._supportedCodeActions = this.client.execute('getSupportedCodeFixes', null, undefined)
.then(response => response.body || [])
.then(codes => codes.map(code => +code).filter(code => !isNaN(code)))
.then(codes =>
codes.reduce((obj, code) => {
obj[code] = true;
return obj;
}, Object.create(null)));
}
return this._supportedCodeActions;
}
}
export default class TypeScriptQuickFixProvider implements vscode.CodeActionProvider {
private readonly supportedCodeActionProvider: SupportedCodeActionProvider;
constructor(
private readonly client: ITypeScriptServiceClient,
private readonly formattingConfigurationManager: FormattingConfigurationManager,
commandManager: CommandManager
) {
commandManager.register(new ApplyCodeActionCommand(client));
this.supportedCodeActionProvider = new SupportedCodeActionProvider(client);
}
public async provideCodeActions(
@@ -57,7 +88,7 @@ export default class TypeScriptQuickFixProvider implements vscode.CodeActionProv
return [];
}
const supportedActions = await this.getSupportedActionsForContext(context);
const supportedActions = await this.supportedCodeActionProvider.getSupportedActionsForContext(context);
if (!supportedActions.size) {
return [];
}
@@ -72,27 +103,6 @@ export default class TypeScriptQuickFixProvider implements vscode.CodeActionProv
return (response.body || []).map(action => this.getCommandForAction(action));
}
private get supportedCodeActions(): Thenable<NumberSet> {
if (!this._supportedCodeActions) {
this._supportedCodeActions = this.client.execute('getSupportedCodeFixes', null, undefined)
.then(response => response.body || [])
.then(codes => codes.map(code => +code).filter(code => !isNaN(code)))
.then(codes =>
codes.reduce((obj, code) => {
obj[code] = true;
return obj;
}, Object.create(null)));
}
return this._supportedCodeActions;
}
private async getSupportedActionsForContext(context: vscode.CodeActionContext): Promise<Set<number>> {
const supportedActions = await this.supportedCodeActions;
return new Set(context.diagnostics
.map(diagnostic => +diagnostic.code)
.filter(code => supportedActions[code]));
}
private getCommandForAction(tsAction: Proto.CodeAction): vscode.CodeAction {
const codeAction = new vscode.CodeAction(tsAction.description, getEditForCodeAction(this.client, tsAction));
if (tsAction.commands) {