From 5b8fe0ed3e34df8075a0e619fad72087cd6b6ddf Mon Sep 17 00:00:00 2001 From: Benjamin Christopher Simmonds <44439583+benibenj@users.noreply.github.com> Date: Fri, 9 Feb 2024 16:47:22 +0100 Subject: [PATCH] Fix smoke test (#204836) fix smoke test --- test/automation/src/extensions.ts | 7 ++++++- test/smoke/src/areas/extensions/extensions.test.ts | 2 +- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/test/automation/src/extensions.ts b/test/automation/src/extensions.ts index 1d0f97dadf3..41dc79d442d 100644 --- a/test/automation/src/extensions.ts +++ b/test/automation/src/extensions.ts @@ -41,7 +41,12 @@ export class Extensions extends Viewlet { } async closeExtension(title: string): Promise { - await this.code.waitAndClick(`.tabs-container div.tab[aria-label="Extension: ${title}"] div.tab-actions a.action-label.codicon.codicon-close`); + try { + await this.code.waitAndClick(`.tabs-container div.tab[aria-label="Extension: ${title}, preview"] div.tab-actions a.action-label.codicon.codicon-close`); + } catch (e) { + this.code.logger.log(`Extension '${title}' not opened as preview. Trying without 'preview'.`); + await this.code.waitAndClick(`.tabs-container div.tab[aria-label="Extension: ${title}"] div.tab-actions a.action-label.codicon.codicon-close`); + } } async installExtension(id: string, waitUntilEnabled: boolean): Promise { diff --git a/test/smoke/src/areas/extensions/extensions.test.ts b/test/smoke/src/areas/extensions/extensions.test.ts index 8a7522c6ea7..c78cbe87089 100644 --- a/test/smoke/src/areas/extensions/extensions.test.ts +++ b/test/smoke/src/areas/extensions/extensions.test.ts @@ -12,7 +12,7 @@ export function setup(logger: Logger) { // Shared before/after handling installAllHandlers(logger); - it.skip('install and enable vscode-smoketest-check extension', async function () { + it('install and enable vscode-smoketest-check extension', async function () { const app = this.app as Application; await app.workbench.extensions.installExtension('ms-vscode.vscode-smoketest-check', true);