Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-27 12:04:04 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fixes #144518: Improve activation logic around handling dependencies

Browse Source
This commit is contained in:
Alex Dima
2022-03-09 21:42:59 +01:00
parent d7ffa37a73
commit 5c20802742
2 changed files with 161 additions and 133 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
src/vs/workbench/api/test/common/extHostExtensionActivator.test.ts
View File

@@ -164,6 +164,31 @@ suite('ExtensionsActivator', () => {
assert.deepStrictEqual(host.errors[1][0], idA);
});
test('issue #144518: Problem with git extension and vscode-icons', async () => {
const extActivationA = new ExtensionActivationPromiseSource();
const extActivationB = new ExtensionActivationPromiseSource();
const extActivationC = new ExtensionActivationPromiseSource();
const host = new PromiseExtensionsActivatorHost([
[idA, extActivationA],
[idB, extActivationB],
[idC, extActivationC]
]);
const activator = createActivator(host, [
desc(idA, [idB]),
desc(idB),
desc(idC),
]);
activator.activateByEvent('*', false);
assert.deepStrictEqual(host.activateCalls, [idB, idC]);
extActivationB.resolve();
await timeout(0);
assert.deepStrictEqual(host.activateCalls, [idB, idC, idA]);
extActivationA.resolve();
});
class SimpleExtensionsActivatorHost implements IExtensionsActivatorHost {
public readonly activateCalls: ExtensionIdentifier[] = [];
public readonly errors: [ExtensionIdentifier, Error | null, MissingExtensionDependency | null][] = [];