Fixes #8379: validate column argument of vscode.previewHtml

This commit is contained in:
Alex Dima
2016-06-28 16:21:18 +02:00
parent 8b1c540ca3
commit 5d218261e8
3 changed files with 13 additions and 6 deletions

View File

@@ -85,13 +85,20 @@ export class ExtHostCommands {
if (!command) {
return Promise.reject<T>(`Contributed command '${id}' does not exist.`);
}
try {
let {callback, thisArg, description} = command;
if (description) {
for (let i = 0; i < description.args.length; i++) {
let {callback, thisArg, description} = command;
if (description) {
for (let i = 0; i < description.args.length; i++) {
try {
validateConstraint(args[i], description.args[i].constraint);
} catch (err) {
return Promise.reject<T>(`Running the contributed command:'${id}' failed. Illegal argument '${description.args[i].name}' - ${description.args[i].description}`);
}
}
}
try {
let result = callback.apply(thisArg, args);
return Promise.resolve(result);
} catch (err) {