From 5d650cd8178453a2d4cc22936c796ccea28d0c77 Mon Sep 17 00:00:00 2001 From: Jackson Kearl Date: Wed, 3 Feb 2021 10:37:40 -0800 Subject: [PATCH] Allow setting startupEditor to `readme` as either default value or user value. Fix github/codespaces#1580 --- .../workbench/contrib/welcome/page/browser/welcomePage.ts | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/vs/workbench/contrib/welcome/page/browser/welcomePage.ts b/src/vs/workbench/contrib/welcome/page/browser/welcomePage.ts index 63b1b51442a..99382e5c634 100644 --- a/src/vs/workbench/contrib/welcome/page/browser/welcomePage.ts +++ b/src/vs/workbench/contrib/welcome/page/browser/welcomePage.ts @@ -72,7 +72,12 @@ export class WelcomePageContribution implements IWorkbenchContribution { // Open the welcome even if we opened a set of default editors if ((!editorService.activeEditor || layoutService.openedDefaultEditors) && !hasBackups) { const startupEditorSetting = configurationService.inspect(configurationKey); - const openWithReadme = startupEditorSetting.userValue === 'readme'; + + // 'readme' should not be set in workspace settings to prevent tracking, + // but it can be set as a default (as in codespaces) or a user setting + const openWithReadme = startupEditorSetting.value === 'readme' && + (startupEditorSetting.userValue === 'readme' || startupEditorSetting.defaultValue === 'readme'); + if (openWithReadme) { return Promise.all(contextService.getWorkspace().folders.map(folder => { const folderUri = folder.uri;