Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-19 08:08:39 +01:00
Code Issues Packages Projects Releases Wiki Activity

validate telemetry sender when creating a logger (#171842)

Browse Source 
fixes https://github.com/microsoft/vscode/issues/170073
This commit is contained in:
Johannes Rieken
2023-01-20 17:58:07 +01:00
committed by GitHub
parent 3d2e10fa6e
commit 5dbb41f91d
3 changed files with 56 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/vs/workbench/api/common/extHost.api.impl.ts
View File

@@ -81,7 +81,7 @@ import { ExtHostTesting } from 'vs/workbench/api/common/extHostTesting';
import { ExtHostUriOpeners } from 'vs/workbench/api/common/extHostUriOpener';
import { IExtHostSecretState } from 'vs/workbench/api/common/extHostSecretState';
import { IExtHostEditorTabs } from 'vs/workbench/api/common/extHostEditorTabs';
import { IExtHostTelemetry, isNewAppInstall } from 'vs/workbench/api/common/extHostTelemetry';
import { ExtHostTelemetryLogger, IExtHostTelemetry, isNewAppInstall } from 'vs/workbench/api/common/extHostTelemetry';
import { ExtHostNotebookKernels } from 'vs/workbench/api/common/extHostNotebookKernels';
import { TextSearchCompleteMessageType } from 'vs/workbench/services/search/common/searchExtTypes';
import { ExtHostNotebookRenderers } from 'vs/workbench/api/common/extHostNotebookRenderers';
@@ -336,9 +336,10 @@ export function createApiFactoryAndRegisterActors(accessor: ServicesAccessor): I
get isNewAppInstall() {
return isNewAppInstall(initData.telemetryInfo.firstSessionDate);
},
createTelemetryLogger(appender: vscode.TelemetrySender): vscode.TelemetryLogger {
createTelemetryLogger(sender: vscode.TelemetrySender): vscode.TelemetryLogger {
checkProposedApiEnabled(extension, 'telemetryLogger');
return extHostTelemetry.instantiateLogger(extension, appender);
ExtHostTelemetryLogger.validateSender(sender);
return extHostTelemetry.instantiateLogger(extension, sender);
},
openExternal(uri: URI, options?: { allowContributedOpeners?: boolean | string }) {
return extHostWindow.openUri(uri, {