Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-24 02:28:34 +01:00
Code Issues Packages Projects Releases Wiki Activity

edits fixes (#238826)

Browse Source 
one inline chat session per file, fix revealing for 1+n requests
This commit is contained in:
Johannes Rieken
2025-01-27 10:35:39 +01:00
committed by GitHub
parent 0d9cdc335d
commit 5e38f282a2
4 changed files with 35 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
src/vs/workbench/contrib/inlineChat/browser/inlineChatSessionServiceImpl.ts
View File

@@ -33,6 +33,7 @@ import { ITextFileService } from '../../../services/textfile/common/textfiles.js
import { IChatEditingService, WorkingSetEntryState } from '../../chat/common/chatEditingService.js';
import { assertType } from '../../../../base/common/types.js';
import { autorun } from '../../../../base/common/observable.js';
import { ResourceMap } from '../../../../base/common/map.js';
type SessionData = {
@@ -318,7 +319,7 @@ export class InlineChatSessionServiceImpl implements IInlineChatSessionService {
// ---- NEW
private readonly _sessions2 = new Map<string, IInlineChatSession2>();
private readonly _sessions2 = new ResourceMap<IInlineChatSession2>();
private readonly _onDidChangeSessions = this._store.add(new Emitter<this>());
readonly onDidChangeSessions: Event<this> = this._onDidChangeSessions.event;
@@ -328,8 +329,7 @@ export class InlineChatSessionServiceImpl implements IInlineChatSessionService {
assertType(editor.hasModel());
const key = this._key(editor, uri);
if (this._sessions2.has(key)) {
if (this._sessions2.has(uri)) {
throw new Error('Session already exists');
}
@@ -343,7 +343,7 @@ export class InlineChatSessionServiceImpl implements IInlineChatSessionService {
const store = new DisposableStore();
store.add(toDisposable(() => {
editingSession.reject();
this._sessions2.delete(key);
this._sessions2.delete(uri);
this._onDidChangeSessions.fire(this);
}));
store.add(editingSession);
@@ -365,14 +365,13 @@ export class InlineChatSessionServiceImpl implements IInlineChatSessionService {
editingSession,
dispose: store.dispose.bind(store)
};
this._sessions2.set(key, result);
this._sessions2.set(uri, result);
this._onDidChangeSessions.fire(this);
return result;
}
getSession2(editor: ICodeEditor, uri: URI): IInlineChatSession2 | undefined {
const key = this._key(editor, uri);
return this._sessions2.get(key);
getSession2(uri: URI): IInlineChatSession2 | undefined {
return this._sessions2.get(uri);
}
}