Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-24 18:49:00 +01:00
Code Issues Packages Projects Releases Wiki Activity

Clean up some editor input debt and lifecycle issues (#24439)

Browse Source
This commit is contained in:
Benjamin Pasero
2017-04-10 19:37:42 +02:00
committed by GitHub
parent ec89a599b3
commit 5ecf0cda9a
33 changed files with 788 additions and 562 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
extensions/vscode-api-tests/src/editor.test.ts
View File

@@ -128,12 +128,18 @@ suite('editor tests', () => {
});
return Promise.all([
commands.executeCommand('workbench.action.closeAllEditors'),
delay(800).then(() => commands.executeCommand('workbench.action.closeAllEditors')), // TODO@Ben TODO@Joh this delay is a hack
p
]).then(() => undefined);
});
});
function delay(time) {
return new Promise(function (fulfill) {
setTimeout(fulfill, time);
});
}
test('issue #20867: vscode.window.visibleTextEditors returns closed document 2/2', () => {
const file10Path = join(workspace.rootPath || '', './10linefile.ts');
@@ -165,8 +171,11 @@ suite('editor tests', () => {
// hide doesn't what it means because it triggers a close event and because it
// detached the editor. For this test that's what we want.
editors[0].hide();
return p;
delay(800).then(() => { // TODO@Ben TODO@Joh this delay is a hack
editors[0].hide();
return p;
});
});
});

2
extensions/vscode-api-tests/src/workspace.test.ts
View File

@@ -60,7 +60,7 @@ suite('workspace-namespace', () => {
test('openTextDocument', () => {
let len = workspace.textDocuments.length;
return workspace.openTextDocument(join(workspace.rootPath || '', './far.js')).then(doc => {
return workspace.openTextDocument(join(workspace.rootPath || '', './simple.txt')).then(doc => {
assert.ok(doc);
assert.equal(workspace.textDocuments.length, len + 1);
});