Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-24 10:38:59 +01:00
Code Issues Packages Projects Releases Wiki Activity

Don't treat dom properties as special for syntax highlighting

Browse Source 
See https://github.com/Microsoft/TypeScript-TmLanguage/issues/691

Assuming that properties named `label` or `name` are dom properties is incorrect and causes a lot of false positives. This results in weirdly inconsistent colorization
This commit is contained in:
Matt Bierner
2019-01-02 17:33:50 -08:00
parent 5631529791
commit 5ed55a8606
10 changed files with 62 additions and 256 deletions
Download Patch File Download Diff File Expand all files Collapse all files

32
extensions/javascript/test/colorize-results/test_jsx.json
View File

@@ -573,13 +573,13 @@
},
{
"c": "preventDefault",
"t": "source.js.jsx meta.var.expr.js.jsx meta.objectliteral.js.jsx meta.object.member.js.jsx meta.function.expression.js.jsx meta.block.js.jsx meta.function-call.js.jsx support.function.dom.js.jsx",
"t": "source.js.jsx meta.var.expr.js.jsx meta.objectliteral.js.jsx meta.object.member.js.jsx meta.function.expression.js.jsx meta.block.js.jsx meta.function-call.js.jsx entity.name.function.js.jsx",
"r": {
"dark_plus": "support.function: #DCDCAA",
"light_plus": "support.function: #795E26",
"dark_plus": "entity.name.function: #DCDCAA",
"light_plus": "entity.name.function: #795E26",
"dark_vs": "default: #D4D4D4",
"light_vs": "default: #000000",
"hc_black": "support.function: #DCDCAA"
"hc_black": "entity.name.function: #DCDCAA"
}
},
{
@@ -1475,13 +1475,13 @@
},
{
"c": "alt",
"t": "source.js.jsx meta.var.expr.js.jsx meta.objectliteral.js.jsx meta.object.member.js.jsx meta.function.expression.js.jsx meta.block.js.jsx meta.block.js.jsx support.variable.property.dom.js.jsx",
"t": "source.js.jsx meta.var.expr.js.jsx meta.objectliteral.js.jsx meta.object.member.js.jsx meta.function.expression.js.jsx meta.block.js.jsx meta.block.js.jsx variable.other.property.js.jsx",
"r": {
"dark_plus": "support.variable: #9CDCFE",
"light_plus": "support.variable: #001080",
"dark_plus": "variable: #9CDCFE",
"light_plus": "variable: #001080",
"dark_vs": "default: #D4D4D4",
"light_vs": "default: #000000",
"hc_black": "support.variable: #9CDCFE"
"hc_black": "variable: #9CDCFE"
}
},
{
@@ -2344,13 +2344,13 @@
},
{
"c": "document",
"t": "source.js.jsx support.variable.dom.js.jsx",
"t": "source.js.jsx variable.other.object.js.jsx",
"r": {
"dark_plus": "support.variable: #9CDCFE",
"light_plus": "support.variable: #001080",
"dark_plus": "variable: #9CDCFE",
"light_plus": "variable: #001080",
"dark_vs": "default: #D4D4D4",
"light_vs": "default: #000000",
"hc_black": "support.variable: #9CDCFE"
"hc_black": "variable: #9CDCFE"
}
},
{
@@ -2366,13 +2366,13 @@
},
{
"c": "body",
"t": "source.js.jsx support.variable.property.dom.js.jsx",
"t": "source.js.jsx variable.other.property.js.jsx",
"r": {
"dark_plus": "support.variable: #9CDCFE",
"light_plus": "support.variable: #001080",
"dark_plus": "variable: #9CDCFE",
"light_plus": "variable: #001080",
"dark_vs": "default: #D4D4D4",
"light_vs": "default: #000000",
"hc_black": "support.variable: #9CDCFE"
"hc_black": "variable: #9CDCFE"
}
},
{