Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2025-12-24 12:19:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

Don't treat dom properties as special for syntax highlighting

Browse Source 
See https://github.com/Microsoft/TypeScript-TmLanguage/issues/691

Assuming that properties named `label` or `name` are dom properties is incorrect and causes a lot of false positives. This results in weirdly inconsistent colorization
This commit is contained in:
Matt Bierner
2019-01-02 17:33:50 -08:00
parent 5631529791
commit 5ed55a8606
10 changed files with 62 additions and 256 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
extensions/typescript-basics/test/colorize-results/test-function-inv_ts.json
View File

@@ -23,13 +23,13 @@
},
{
"c": "push",
"t": "source.ts meta.function-call.ts support.function.ts",
"t": "source.ts meta.function-call.ts entity.name.function.ts",
"r": {
"dark_plus": "support.function: #DCDCAA",
"light_plus": "support.function: #795E26",
"dark_plus": "entity.name.function: #DCDCAA",
"light_plus": "entity.name.function: #795E26",
"dark_vs": "default: #D4D4D4",
"light_vs": "default: #000000",
"hc_black": "support.function: #DCDCAA"
"hc_black": "entity.name.function: #DCDCAA"
}
},
{

16
extensions/typescript-basics/test/colorize-results/test_ts.json
View File

@@ -9153,13 +9153,13 @@
},
{
"c": "push",
"t": "source.ts meta.namespace.declaration.ts meta.block.ts meta.class.ts meta.method.declaration.ts meta.block.ts meta.block.ts meta.block.ts meta.function-call.ts support.function.ts",
"t": "source.ts meta.namespace.declaration.ts meta.block.ts meta.class.ts meta.method.declaration.ts meta.block.ts meta.block.ts meta.block.ts meta.function-call.ts entity.name.function.ts",
"r": {
"dark_plus": "support.function: #DCDCAA",
"light_plus": "support.function: #795E26",
"dark_plus": "entity.name.function: #DCDCAA",
"light_plus": "entity.name.function: #795E26",
"dark_vs": "default: #D4D4D4",
"light_vs": "default: #000000",
"hc_black": "support.function: #DCDCAA"
"hc_black": "entity.name.function: #DCDCAA"
}
},
{
@@ -9406,13 +9406,13 @@
},
{
"c": "push",
"t": "source.ts meta.namespace.declaration.ts meta.block.ts meta.class.ts meta.method.declaration.ts meta.block.ts meta.block.ts meta.function-call.ts support.function.ts",
"t": "source.ts meta.namespace.declaration.ts meta.block.ts meta.class.ts meta.method.declaration.ts meta.block.ts meta.block.ts meta.function-call.ts entity.name.function.ts",
"r": {
"dark_plus": "support.function: #DCDCAA",
"light_plus": "support.function: #795E26",
"dark_plus": "entity.name.function: #DCDCAA",
"light_plus": "entity.name.function: #795E26",
"dark_vs": "default: #D4D4D4",
"light_vs": "default: #000000",
"hc_black": "support.function: #DCDCAA"
"hc_black": "entity.name.function: #DCDCAA"
}
},
{