From e51320551dd5ee652b68d3f2a3009dce7a94f6d3 Mon Sep 17 00:00:00 2001 From: Matheus Salmi Date: Thu, 22 Feb 2018 01:04:51 -0300 Subject: [PATCH 1/3] Fix #44032 - make php grammar regex case-insensitive --- extensions/php/build/update-grammar.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/extensions/php/build/update-grammar.js b/extensions/php/build/update-grammar.js index 94b73aa73547..22e0a05d9887 100644 --- a/extensions/php/build/update-grammar.js +++ b/extensions/php/build/update-grammar.js @@ -27,7 +27,7 @@ function fixBadRegex(grammar) { if (scopeResolution) { const match = scopeResolution.patterns[0].match; if (match === '(?i)([a-z_\\x{7f}-\\x{7fffffff}\\\\][a-z0-9_\\x{7f}-\\x{7fffffff}\\\\]*)(?=\\s*::)') { - scopeResolution.patterns[0].match = '([A-Za-z_\\x{7f}-\\x{7fffffff}\\\\][A_Za-z0-9_\\x{7f}-\\x{7fffffff}\\\\]*)(?=\\s*::)'; + scopeResolution.patterns[0].match = '([A-Za-z_\\x{7f}-\\x{7fffffff}\\\\][A-Za-z0-9_\\x{7f}-\\x{7fffffff}\\\\]*)(?=\\s*::)'; return; } } From 2896341a863f711376a897b288427bd5073d1852 Mon Sep 17 00:00:00 2001 From: Matheus Salmi Date: Thu, 22 Feb 2018 01:06:42 -0300 Subject: [PATCH 2/3] Update php grammar file --- extensions/php/syntaxes/php.tmLanguage.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/extensions/php/syntaxes/php.tmLanguage.json b/extensions/php/syntaxes/php.tmLanguage.json index 9940c6180831..f26a1e7daf53 100644 --- a/extensions/php/syntaxes/php.tmLanguage.json +++ b/extensions/php/syntaxes/php.tmLanguage.json @@ -2430,7 +2430,7 @@ "scope-resolution": { "patterns": [ { - "match": "([A-Za-z_\\x{7f}-\\x{7fffffff}\\\\][A_Za-z0-9_\\x{7f}-\\x{7fffffff}\\\\]*)(?=\\s*::)", + "match": "([A-Za-z_\\x{7f}-\\x{7fffffff}\\\\][A-Za-z0-9_\\x{7f}-\\x{7fffffff}\\\\]*)(?=\\s*::)", "captures": { "1": { "patterns": [ From eb551fda39ba6a220f891719759e841853afe08f Mon Sep 17 00:00:00 2001 From: Rob Lourens Date: Wed, 7 Mar 2018 17:47:09 -0800 Subject: [PATCH 3/3] Fix #44496 - The li parent of the action item is getting 4 extra px from somewhere --- src/vs/workbench/parts/search/browser/media/searchview.css | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/vs/workbench/parts/search/browser/media/searchview.css b/src/vs/workbench/parts/search/browser/media/searchview.css index ac7693e0a3f2..3aebda9dbc61 100644 --- a/src/vs/workbench/parts/search/browser/media/searchview.css +++ b/src/vs/workbench/parts/search/browser/media/searchview.css @@ -53,6 +53,10 @@ margin-left: 3px; } +.search-view .search-widget .replace-container .monaco-action-bar { + height: 25px; +} + .search-view .search-widget .replace-container .monaco-action-bar .action-item .icon { background-repeat: no-repeat; width: 20px;